From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 10 Aug 2021 11:58:53 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mDOX7-0002ui-G9 for lore@lore.pengutronix.de; Tue, 10 Aug 2021 11:58:53 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mDOX7-0000BA-3v; Tue, 10 Aug 2021 11:58:53 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDOWd-0000B2-U4 for ptxdist@pengutronix.de; Tue, 10 Aug 2021 11:58:23 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mDOWd-00011V-Jn for ptxdist@pengutronix.de; Tue, 10 Aug 2021 11:58:23 +0200 Date: Tue, 10 Aug 2021 11:58:23 +0200 From: Roland Hieber To: ptxdist@pengutronix.de Message-ID: <20210810095823.cbinuomdzwtczuxc@pengutronix.de> References: <20210809144030.22764-1-rhi@pengutronix.de> <20210809144030.22764-3-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210809144030.22764-3-rhi@pengutronix.de> User-Agent: NeoMutt/20180716 Subject: Re: [ptxdist] [PATCH 3/3] ptxd_lib_code_signing: let providers clean up their keys X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Aug 09, 2021 at 04:40:30PM +0200, Roland Hieber wrote: > Currently, sysroot-host/var/lib/keys/${keyprovider} is left over even > when the provider package is cleaned. To help with this, introduce > cs_clean and cs_clean_softhsm shell functions. The latter needs access > to ${shsm_keys}, so move its definition into cs_init_variables (even if > this function is not only meant for the SoftHSM workflow, the additional > variable makes no trouble here). Call the cleanup functions in the clean > stage of the providers, and also at the beginning of the compile stage > to ensure a clean setup. For the latter, introduce cs_init for the > non-SoftHSM use case. > > Reported-by: Bastian Stender > Signed-off-by: Roland Hieber Bastian had some remarks offline, see v2 of this series. - Roland -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de