From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 06 Aug 2021 08:44:35 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mBtat-00076H-3K for lore@lore.pengutronix.de; Fri, 06 Aug 2021 08:44:35 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1mBtas-0005mC-Na; Fri, 06 Aug 2021 08:44:34 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBtaf-0005lr-SV; Fri, 06 Aug 2021 08:44:21 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mBtaf-0005cO-JN; Fri, 06 Aug 2021 08:44:21 +0200 Date: Fri, 6 Aug 2021 08:44:21 +0200 From: Michael Olbrich To: Roland Hieber Message-ID: <20210806064421.GM21333@pengutronix.de> Mail-Followup-To: Roland Hieber , Ahmad Fatoum , ptxdist@pengutronix.de References: <20210727140535.11083-1-a.fatoum@pengutronix.de> <20210728094832.wa6afqtjxlkjan6t@pengutronix.de> <20210802083343.lltjmtcm3xv3baq3@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210802083343.lltjmtcm3xv3baq3@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:38:31 up 169 days, 10:02, 73 users, load average: 0.21, 0.14, 0.10 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] fscryptctl: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de, Ahmad Fatoum Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi, On Mon, Aug 02, 2021 at 10:33:43AM +0200, Roland Hieber wrote: > On Mon, Aug 02, 2021 at 07:45:26AM +0200, Ahmad Fatoum wrote: > > On 28.07.21 11:48, Roland Hieber wrote: > > > On Tue, Jul 27, 2021 at 04:05:35PM +0200, Ahmad Fatoum wrote: > > >> diff --git a/rules/fscryptctl.make b/rules/fscryptctl.make > > >> new file mode 100644 > > >> index 000000000000..7520ab37c203 > > >> --- /dev/null > > >> +++ b/rules/fscryptctl.make > > >> @@ -0,0 +1,53 @@ > > >> +# -*-makefile-*- > > >> +# > > >> +# Copyright (C) 2021 by Ahmad Fatoum > > >> +# > > >> + > > >> +PACKAGES-$(PTXCONF_FSCRYPTCTL) += fscryptctl > > >> + > > >> +# > > >> +# Paths and names > > >> +# > > >> +FSCRYPTCTL_VERSION := 1.0.0 > > >> +FSCRYPTCTL_MD5 := 1013d00ac166b233631100e5905004cc > > >> +FSCRYPTCTL := fscryptctl-$(FSCRYPTCTL_VERSION) > > >> +FSCRYPTCTL_SUFFIX := tar.gz > > >> +FSCRYPTCTL_URL := https://github.com/google/fscryptctl/archive/v$(FSCRYPTCTL_VERSION).$(FSCRYPTCTL_SUFFIX) > > >> +FSCRYPTCTL_SOURCE := $(SRCDIR)/$(FSCRYPTCTL).$(FSCRYPTCTL_SUFFIX) > > >> +FSCRYPTCTL_DIR := $(BUILDDIR)/$(FSCRYPTCTL) > > >> +FSCRYPTCTL_LICENSE := Apache-2.0 > > > > > > FSCRYPTCTL_LICENSE_FILES := \ > > > file://fscryptctl.c;startline=5;endline=20;md5=989e571b78197682b85e3643d13296e5 \ > > > file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57 > > > > > > (Please check by running "ptxdist licensecheck fscryptctl" after adding > > > these lines.) > > > > Thanks. I just sent out a v2 with your suggested FSCRYPTCTL_LICENSE_FILES. > > I didn't take startline=5 however, because that includes Google copyright > > (with year) and author names. I bumped it to startline=10, which starts with: > > Yes, startline=5 was deliberate to include the copyright statement. This > way it is reproduced in the license-report.pdf. I agree with Roland here. Including the Copyright statement is a good idea. It may not be strictly necessary for Apache-2.0 (I'm not sure), but it's better to be consistent here. And changing copyright years a really not a problem. You're supposed to check if the License changed anyways and a changing md5 is a good reminder to do so. So I've modified the _LICENSE_FILES to Roland initial suggestion while applying the patch. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de