Re: [ptxdist] [PATCH] fscryptctl: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Mon, Aug 02, 2021 at 10:33:43AM +0200, Roland Hieber wrote:
> On Mon, Aug 02, 2021 at 07:45:26AM +0200, Ahmad Fatoum wrote:
> > On 28.07.21 11:48, Roland Hieber wrote:
> > > On Tue, Jul 27, 2021 at 04:05:35PM +0200, Ahmad Fatoum wrote:
> > >> diff --git a/rules/fscryptctl.make b/rules/fscryptctl.make
> > >> new file mode 100644
> > >> index 000000000000..7520ab37c203
> > >> --- /dev/null
> > >> +++ b/rules/fscryptctl.make
> > >> @@ -0,0 +1,53 @@
> > >> +# -*-makefile-*-
> > >> +#
> > >> +# Copyright (C) 2021 by Ahmad Fatoum <a.fatoum@pengutronix.de>
> > >> +#
> > >> +
> > >> +PACKAGES-$(PTXCONF_FSCRYPTCTL) += fscryptctl
> > >> +
> > >> +#
> > >> +# Paths and names
> > >> +#
> > >> +FSCRYPTCTL_VERSION	:= 1.0.0
> > >> +FSCRYPTCTL_MD5		:= 1013d00ac166b233631100e5905004cc
> > >> +FSCRYPTCTL		:= fscryptctl-$(FSCRYPTCTL_VERSION)
> > >> +FSCRYPTCTL_SUFFIX	:= tar.gz
> > >> +FSCRYPTCTL_URL		:= https://github.com/google/fscryptctl/archive/v$(FSCRYPTCTL_VERSION).$(FSCRYPTCTL_SUFFIX)
> > >> +FSCRYPTCTL_SOURCE	:= $(SRCDIR)/$(FSCRYPTCTL).$(FSCRYPTCTL_SUFFIX)
> > >> +FSCRYPTCTL_DIR		:= $(BUILDDIR)/$(FSCRYPTCTL)
> > >> +FSCRYPTCTL_LICENSE	:= Apache-2.0
> > > 
> > > FSCRYPTCTL_LICENSE_FILES	:= \
> > > 	file://fscryptctl.c;startline=5;endline=20;md5=989e571b78197682b85e3643d13296e5 \
> > > 	file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57
> > > 
> > > (Please check by running "ptxdist licensecheck fscryptctl" after adding
> > > these lines.)
> > 
> > Thanks. I just sent out a v2 with your suggested FSCRYPTCTL_LICENSE_FILES.
> > I didn't take startline=5 however, because that includes Google copyright
> > (with year) and author names. I bumped it to startline=10, which starts with:
> 
> Yes, startline=5 was deliberate to include the copyright statement. This
> way it is reproduced in the license-report.pdf.

I agree with Roland here. Including the Copyright statement is a good idea.
It may not be strictly necessary for Apache-2.0 (I'm not sure), but it's
better to be consistent here.
And changing copyright years a really not a problem. You're supposed to
check if the License changed anyways and a changing md5 is a good reminder
to do so.

So I've modified the _LICENSE_FILES to Roland initial suggestion while
applying the patch.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de