mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] fscryptctl: new package
Date: Mon, 2 Aug 2021 10:33:43 +0200	[thread overview]
Message-ID: <20210802083343.lltjmtcm3xv3baq3@pengutronix.de> (raw)
In-Reply-To: <c0e902cc-2eb3-a90c-b25d-bfbc1f8d3322@pengutronix.de>

On Mon, Aug 02, 2021 at 07:45:26AM +0200, Ahmad Fatoum wrote:
> Hi Roland,
> 
> On 28.07.21 11:48, Roland Hieber wrote:
> > On Tue, Jul 27, 2021 at 04:05:35PM +0200, Ahmad Fatoum wrote:
> >> diff --git a/rules/fscryptctl.make b/rules/fscryptctl.make
> >> new file mode 100644
> >> index 000000000000..7520ab37c203
> >> --- /dev/null
> >> +++ b/rules/fscryptctl.make
> >> @@ -0,0 +1,53 @@
> >> +# -*-makefile-*-
> >> +#
> >> +# Copyright (C) 2021 by Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> +#
> >> +
> >> +PACKAGES-$(PTXCONF_FSCRYPTCTL) += fscryptctl
> >> +
> >> +#
> >> +# Paths and names
> >> +#
> >> +FSCRYPTCTL_VERSION	:= 1.0.0
> >> +FSCRYPTCTL_MD5		:= 1013d00ac166b233631100e5905004cc
> >> +FSCRYPTCTL		:= fscryptctl-$(FSCRYPTCTL_VERSION)
> >> +FSCRYPTCTL_SUFFIX	:= tar.gz
> >> +FSCRYPTCTL_URL		:= https://github.com/google/fscryptctl/archive/v$(FSCRYPTCTL_VERSION).$(FSCRYPTCTL_SUFFIX)
> >> +FSCRYPTCTL_SOURCE	:= $(SRCDIR)/$(FSCRYPTCTL).$(FSCRYPTCTL_SUFFIX)
> >> +FSCRYPTCTL_DIR		:= $(BUILDDIR)/$(FSCRYPTCTL)
> >> +FSCRYPTCTL_LICENSE	:= Apache-2.0
> > 
> > FSCRYPTCTL_LICENSE_FILES	:= \
> > 	file://fscryptctl.c;startline=5;endline=20;md5=989e571b78197682b85e3643d13296e5 \
> > 	file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57
> > 
> > (Please check by running "ptxdist licensecheck fscryptctl" after adding
> > these lines.)
> 
> Thanks. I just sent out a v2 with your suggested FSCRYPTCTL_LICENSE_FILES.
> I didn't take startline=5 however, because that includes Google copyright
> (with year) and author names. I bumped it to startline=10, which starts with:

Yes, startline=5 was deliberate to include the copyright statement. This
way it is reproduced in the license-report.pdf.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-08-02  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 14:05 Ahmad Fatoum
2021-07-28  9:48 ` Roland Hieber
2021-08-02  5:45   ` Ahmad Fatoum
2021-08-02  8:33     ` Roland Hieber [this message]
2021-08-06  6:44       ` Michael Olbrich
2021-08-06  6:51         ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802083343.lltjmtcm3xv3baq3@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox