From: Roland Hieber <rhi@pengutronix.de> To: Christian Melki <christian.melki@t2data.com> Cc: ptxdist@pengutronix.de Subject: Re: [ptxdist] [PATCH 2/6] rules/gnu-efi: Add new package. Date: Mon, 19 Jul 2021 11:09:40 +0200 [thread overview] Message-ID: <20210719090940.fcxmdec3kxcdzfji@pengutronix.de> (raw) In-Reply-To: <20210716134107.31712-2-christian.melki@t2data.com> Hi, generally you can just prefix the commit message with the package name (no "rules/"), that's how we usually do it. And no dot at the end of the message. More below: On Fri, Jul 16, 2021 at 03:41:03PM +0200, Christian Melki wrote: > Target GNU EFI library. Used for various EFI work. > Depending on your needs, target binaries for EFI stuff might be needed. > This is used by efitools etc. > > Signed-off-by: Christian Melki <christian.melki@t2data.com> > --- > rules/gnu-efi.in | 6 ++++ > rules/gnu-efi.make | 71 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 77 insertions(+) > create mode 100644 rules/gnu-efi.in > create mode 100644 rules/gnu-efi.make > > diff --git a/rules/gnu-efi.in b/rules/gnu-efi.in > new file mode 100644 > index 000000000..b21192222 > --- /dev/null > +++ b/rules/gnu-efi.in > @@ -0,0 +1,6 @@ > +## SECTION=system_libraries > +menuconfig GNU_EFI > + tristate > + prompt "gnu-efi " > + help > + This is gnu-efi, a library for providing EFI functions. > diff --git a/rules/gnu-efi.make b/rules/gnu-efi.make > new file mode 100644 > index 000000000..33a27020b > --- /dev/null > +++ b/rules/gnu-efi.make > @@ -0,0 +1,71 @@ > +# -*-makefile-*- > +# > +# Copyright (C) 2021 by Christian Melki <christian.melki@t2data.com> > +# > +# For further information about the PTXdist project and license conditions > +# see the README file. > +# > + > +# > +# We provide this package > +# > +PACKAGES-$(PTXCONF_GNU_EFI) += gnu-efi > + > +# > +# Paths and names > +# > +# No tags: use a fake descriptive commit-ish to include the date > +GNU_EFI_VERSION := 3.0.13 > +GNU_EFI_MD5 := 8ec4221f505c78e6fc375c2fd7f0c549 > +GNU_EFI := gnu-efi-$(GNU_EFI_VERSION) > +GNU_EFI_SUFFIX := tar.bz2 > +GNU_EFI_URL := https://sourceforge.net/projects/gnu-efi/files/gnu-efi-$(GNU_EFI_VERSION).$(GNU_EFI_SUFFIX) > +GNU_EFI_SOURCE := $(SRCDIR)/$(GNU_EFI).$(GNU_EFI_SUFFIX) > +GNU_EFI_DIR := $(BUILDDIR)/$(GNU_EFI) > +GNU_EFI_LICENSE := BSD There are tons of slightly different BSD licenses… :-), please have a look at the SPDX list [0] and choose the correct identifier. Also please add a GNU_EFI_LICENSE_FILES variable as documentation how you came to that conclusion. Or if you feel like skipping this part, "unknown" is the special expression for "no one has looked at this yet". [0]: <https://spdx.org/licenses/> The same applies to other patches in this series. In this case, I found something relevant in README.efilib which applies to the code in lib/ and inc/, but for the rest we'll have to fall back to the comment headers in gnuefi/*.c for the rest. I'm using spdx-license-match [1] here to get a diff between the version that is in README.efilib and the template from SPDX: [1]: <https://github.com/rohieb/spdx-license-match> $ sed -n '19,$p' README.efilib | spdx-license-match -n 3 --guess BSD [...] Hm. All BSD matches are pretty bad, maybe this is not BSD after all? $ sed -n '19,$p' README.efilib | spdx-license-match [...] Hmm. BSD-1-Clause is the best match, but the project license still looks differently, mainly the first clause is missing, and an additional sentence about EFI at the end. So I would classify it as "custom", not BSD. $ sed -n '19,$p' README.efilib | md5sum b1b8d397eda0e4b82e34c7b58610dfcb The headers in gnuefi/*.c look like BSD-3-Clause. $ sed -n 2,35p gnuefi/reloc_x86_64.c | spdx-license-match -g BSD-3 [...] Yes, the diff looks inconspicuous. $ sed -n 2,35p gnuefi/reloc_x86_64.c | md5sum 8f99c3f647f56ad3fb9519d6026af2e2 This gives us: GNU_EFI_LICENSE := custom GNU_EFI_LICENSE_FILES := \ file://README.efilib;startline=19;md5=b1b8d397eda0e4b82e34c7b58610dfcb file://gnuefi/reloc_x86_64.c;startline=2;endline=35;md5=8f99c3f647f56ad3fb9519d6026af2e2 - Roland > + > +# ---------------------------------------------------------------------------- > +# Compile > +# ---------------------------------------------------------------------------- > + > +ifdef PTXCONF_ARCH_X86 > +GNU_EFI_ARCH = ia32 > +ifdef PTXCONF_ARCH_X86_64 > +GNU_EFI_ARCH = x86_64 > +endif > +endif > +ifdef PTXCONF_ARCH_ARM > +GNU_EFI_ARCH = arm > +endif > +ifdef PTXCONF_ARCH_ARM64 > +GNU_EFI_ARCH = aarch64 > +endif > + > +GNU_EFI_CONF_TOOL := NO > +GNU_EFI_MAKE_ENV := \ > + ARCH=$(GNU_EFI_ARCH) \ > + CROSS_COMPILE=$(COMPILER_PREFIX) \ > + PREFIX=/usr \ > + LIBDIR=/usr/$(CROSS_LIB_DIR) > + > +GNU_EFI_INSTALL_OPT := \ > + INSTALLROOT=$(GNU_EFI_PKGDIR) \ > + PREFIX=/usr \ > + LIBDIR=/usr/$(CROSS_LIB_DIR) \ > + install > + > +# ---------------------------------------------------------------------------- > +# Target-Install > +# ---------------------------------------------------------------------------- > + > +$(STATEDIR)/gnu-efi.targetinstall: > + @$(call targetinfo) > + @$(call install_init, gnu-efi) > + @$(call install_fixup, gnu-efi,PRIORITY,optional) > + @$(call install_fixup, gnu-efi,SECTION,base) > + @$(call install_fixup, gnu-efi,AUTHOR,"Christian Melki <christian.melki@t2data.com>") > + @$(call install_fixup, gnu-efi,DESCRIPTION,missing) > + @$(call install_finish, gnu-efi) > + @$(call touch) > + > +# vim: syntax=make > -- > 2.32.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-07-19 9:10 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-16 13:41 [ptxdist] [PATCH 1/6] rules/host-gnu-efi: " Christian Melki 2021-07-16 13:41 ` [ptxdist] [PATCH 2/6] rules/gnu-efi: " Christian Melki 2021-07-19 9:09 ` Roland Hieber [this message] 2021-07-19 9:11 ` Roland Hieber 2021-07-20 13:08 ` Christian Melki 2021-07-20 14:22 ` Roland Hieber 2021-07-16 13:41 ` [ptxdist] [PATCH 3/6] rules/host-efitools: " Christian Melki 2021-07-16 13:41 ` [ptxdist] [PATCH 4/6] rules/efitools: " Christian Melki 2021-07-16 13:41 ` [ptxdist] [PATCH 5/6] rules/host-sbsigntools: " Christian Melki 2021-07-16 13:41 ` [ptxdist] [PATCH 6/6] rules/sbsigntools: " Christian Melki
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210719090940.fcxmdec3kxcdzfji@pengutronix.de \ --to=rhi@pengutronix.de \ --cc=christian.melki@t2data.com \ --cc=ptxdist@pengutronix.de \ --subject='Re: [ptxdist] [PATCH 2/6] rules/gnu-efi: Add new package.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox