mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <post@lespocky.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 4/6] ppp: use HTTPS URL
Date: Fri, 9 Jul 2021 13:12:12 +0200
Message-ID: <20210709111211.iwfd732ultmjojf2@falbala.internal.home.lespocky.de> (raw)
In-Reply-To: <20210709105021.56iwmukpyghnkuyg@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 2426 bytes --]

Hello Roland,

On Fri, Jul 09, 2021 at 12:50:21PM +0200, Roland Hieber wrote:
> On Fri, Jul 09, 2021 at 08:59:08AM +0200, Alexander Dahl wrote:
> > Hello Roland,
> > 
> > On Fri, Jul 09, 2021 at 12:02:02AM +0200, Roland Hieber wrote:
> > > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > 
> > I miss the reasoning for this change. What's the benefit?
> 
> Originally I tried to "fix" it because the nightly urlcheck run failed,
> but it turned out to be a temporary failure on the samba.org side.
> Nevertheless, HTTPS provides more security, 

Downloading some public source tarball without any credentials
necessary, I'm not convinced about the additional value.

> and the HTTP URL redirects
> to HTTPS anyway (same for the other patches in this series).

Well, I could accept that, saves at least a request.

A

> 
>  - Roland
> 
> > 
> > Greets
> > Alex
> > 
> > > ---
> > >  rules/ppp.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/ppp.make b/rules/ppp.make
> > > index 3c8a57fd9396..e39b87b45dd3 100644
> > > --- a/rules/ppp.make
> > > +++ b/rules/ppp.make
> > > @@ -20,7 +20,7 @@ PPP_VERSION	:= 2.4.9
> > >  PPP_MD5		:= c88153ae3d16ae114152cd3c15c7301d
> > >  PPP		:= ppp-$(PPP_VERSION)
> > >  PPP_SUFFIX	:= tar.gz
> > > -PPP_URL		:= http://ftp.samba.org/pub/ppp/$(PPP).$(PPP_SUFFIX)
> > > +PPP_URL		:= https://www.samba.org/ftp/pub/ppp/$(PPP).$(PPP_SUFFIX)
> > >  PPP_SOURCE	:= $(SRCDIR)/$(PPP).$(PPP_SUFFIX)
> > >  PPP_DIR		:= $(BUILDDIR)/$(PPP)
> > >  PPP_LICENSE	:= BSD AND GPL-2.0-only
> > > -- 
> > > 2.30.2
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-07-09 11:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 22:01 [ptxdist] [PATCH 1/6] dbench: " Roland Hieber
2021-07-08 22:02 ` [ptxdist] [PATCH 2/6] linuxptp: version bump 2.0 -> 3.1.1 Roland Hieber
2021-07-08 22:11   ` [ptxdist] [PATCH v2] " Roland Hieber
2021-07-20 11:48     ` [ptxdist] [APPLIED] " Michael Olbrich
2021-07-08 22:02 ` [ptxdist] [PATCH 3/6] linuxptp: pin down license files Roland Hieber
2021-07-20 11:48   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-07-08 22:02 ` [ptxdist] [PATCH 4/6] ppp: use HTTPS URL Roland Hieber
2021-07-09  6:59   ` Alexander Dahl
2021-07-09 10:50     ` Roland Hieber
2021-07-09 11:12       ` Alexander Dahl [this message]
2021-07-20 11:48   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-07-08 22:02 ` [ptxdist] [PATCH 5/6] rsync: " Roland Hieber
2021-07-20 11:48   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-07-08 22:02 ` [ptxdist] [PATCH 6/6] samba: use HTTPS URL in menu help text Roland Hieber
2021-07-20 11:48   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-07-20 11:48 ` [ptxdist] [APPLIED] dbench: use HTTPS URL Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709111211.iwfd732ultmjojf2@falbala.internal.home.lespocky.de \
    --to=post@lespocky.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailarchive of the ptxdist mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.ptxdist.org/ptxdist/0 ptxdist/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ptxdist ptxdist/ https://lore.ptxdist.org/ptxdist \
		ptxdist@pengutronix.de
	public-inbox-index ptxdist

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git