On Wed, Jul 07, 2021 at 04:52:23PM +0200, Bruno Thomsen wrote:
> Den ons. 7. jul. 2021 kl. 16.31 skrev Michael Olbrich
> <m.olbrich@pengutronix.de>:
> >
> > On Mon, Jul 05, 2021 at 09:49:25AM +0200, Uwe Kleine-König wrote:
> > > ---
> > >  ...ke-unrecognized-option-a-fatal-error.patch | 25 -----------------
> > >  patches/chrony-3.5/series                     |  4 ---
> > >  ...t-install-docs-to-not-need-additiona.patch | 21 +++++++++++++++
> > >  ...vice-Make-this-a-non-forking-service.patch | 27 +++++++++++++++++++
> > >  patches/chrony-4.1/series                     |  5 ++++
> > >  rules/chrony.make                             |  4 +--
> > >  6 files changed, 55 insertions(+), 31 deletions(-)
> > >  delete mode 100644 patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
> > >  delete mode 100644 patches/chrony-3.5/series
> > >  create mode 100644 patches/chrony-4.1/0001-Makefile.in-Don-t-install-docs-to-not-need-additiona.patch
> > >  create mode 100644 patches/chrony-4.1/0002-chronyd.service-Make-this-a-non-forking-service.patch
> > >  create mode 100644 patches/chrony-4.1/series
> > >
> > > diff --git a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch b/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
> > > deleted file mode 100644
> > > index 01f2136338b9..000000000000
> > > --- a/patches/chrony-3.5/0001-configure-make-unrecognized-option-a-fatal-error.patch
> > > +++ /dev/null
> > > @@ -1,25 +0,0 @@
> > > -From: Bruno Thomsen <bruno.thomsen@gmail.com>
> > > -Date: Fri, 31 Jul 2020 09:07:49 +0000
> > > -Subject: [PATCH] configure: make unrecognized option a fatal error
> > > -
> > > -This helps catch cases where options has been removed
> > > -and are no longer valid. Including additional cross-build
> > > -options that cannot be used.
> > > -
> > > -Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> 
> Hi,
> 
> This patch was added last year to ptxdist, so it's possible to detect
> unrecognized options in new chrony versions as they use a custom
> hand crafted configure script. So unless that situation has changed
> this patch should be kept.

I dropped it because it is only important when you do a version bump. As
you usually go through all of the configure flags anyhow I didn't
consider it useful enough to keep it.

However I don't feel strong here, so if you do, I can keep it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |