mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] networkmanager: Make "more logging" optional
Date: Tue, 29 Jun 2021 07:09:35 +0200	[thread overview]
Message-ID: <20210629050935.2524954-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20210623073309.23058-5-ada@thorsis.com>

Thanks, applied as fe852c3f4dc34d2e11c641092d19de0d2b3bd5fa.

Michael

[sent from post-receive hook]

On Tue, 29 Jun 2021 07:09:34 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> With build option "more_logging" set to false, it's not possible to
> enable loglevel "debug" in /etc/NetworkManager/NetworkManager.conf
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Message-Id: <20210623073309.23058-5-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/networkmanager.in b/rules/networkmanager.in
> index 6c68d40cc2d6..dae60a0c8d42 100644
> --- a/rules/networkmanager.in
> +++ b/rules/networkmanager.in
> @@ -104,6 +104,12 @@ config NETWORKMANAGER_POLKIT
>  	bool
>  	prompt "polkit support"
>  
> +config NETWORKMANAGER_MORE_LOGGING
> +	bool
> +	prompt "more logging"
> +	help
> +	  Allows debug log level in NetworkManager.conf
> +
>  endif
>  
>  menu "networkmanager plugins        "
> diff --git a/rules/networkmanager.make b/rules/networkmanager.make
> index c39179f5b5d3..022ed7178997 100644
> --- a/rules/networkmanager.make
> +++ b/rules/networkmanager.make
> @@ -64,7 +64,7 @@ NETWORKMANAGER_CONF_OPT = \
>  	-Dmodem_manager=$(call ptx/truefalse,PTXCONF_NETWORKMANAGER_WWAN) \
>  	-Dmodify_system=false \
>  	-Dmore_asserts=no \
> -	-Dmore_logging=false \
> +	-Dmore_logging=$(call ptx/truefalse,PTXCONF_NETWORKMANAGER_MORE_LOGGING) \
>  	-Dnetconfig=false \
>  	-Dnm_cloud_setup=false \
>  	-Dnmcli=$(call ptx/truefalse,PTXCONF_NETWORKMANAGER_NMCLI) \

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-06-29  5:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  7:33 [ptxdist] [PATCH v3 0/5] mobile broadband software version bump Alexander Dahl
2021-06-23  7:33 ` [ptxdist] [PATCH v3 1/5] libqmi: version bump 1.28.2 -> 1.28.6 Alexander Dahl
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-23  7:33 ` [ptxdist] [PATCH v3 2/5] modemmanager: version bump 1.16.2 -> 1.16.6 Alexander Dahl
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-23  7:33 ` [ptxdist] [PATCH v3 3/5] networkmanager: version bump 1.26.2 -> 1.30.4 Alexander Dahl
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-23  7:33 ` [ptxdist] [PATCH v3 4/5] networkmanager: Make "more logging" optional Alexander Dahl
2021-06-29  5:09   ` Michael Olbrich [this message]
2021-06-23  7:33 ` [ptxdist] [PATCH v3 5/5] ppp: version bump 2.4.7 -> 2.4.9 Alexander Dahl
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210629050935.2524954-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    --subject='Re: [ptxdist] [APPLIED] networkmanager: Make "more logging" optional' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox