From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 28 Jun 2021 08:42:20 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1lxkyK-0001UW-Oj
	for lore@lore.pengutronix.de; Mon, 28 Jun 2021 08:42:20 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1lxkyK-0003BG-HZ; Mon, 28 Jun 2021 08:42:20 +0200
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1lxkyD-0003Ad-G5; Mon, 28 Jun 2021 08:42:13 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1lxkyD-0003RZ-7A; Mon, 28 Jun 2021 08:42:13 +0200
Date: Mon, 28 Jun 2021 08:42:13 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Message-ID: <20210628064213.GK25044@pengutronix.de>
Mail-Followup-To: ptxdist@pengutronix.de,
	Roland Hieber <rhi@pengutronix.de>
References: <20210627231121.28313-1-rhi@pengutronix.de>
 <20210627231121.28313-6-rhi@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20210627231121.28313-6-rhi@pengutronix.de>
X-Sent-From: Pengutronix Hildesheim
X-URL: http://www.pengutronix.de/
X-IRC: #ptxdist @freenode
X-Accept-Language: de,en
X-Accept-Content-Type: text/plain
X-Uptime: 08:40:36 up 130 days, 10:04, 111 users,  load average: 0.07, 0.14,
 0.31
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [ptxdist] [PATCH v2 6/7] ptxd_lib_imx_hab: fix indentation
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

On Mon, Jun 28, 2021 at 01:11:20AM +0200, Roland Hieber wrote:
> Be uniform with bin/ptxdist, indent with one tab instead of mixed tabs
> and spaces.

No. Everything is scripts is indented this way: Indention is 4 Spaces
tabwidth is 8 and tabs are not expanded. Blame Marc he started it this way
:-).

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> PATCH v2 (rhi):
>  - new patch in v2
>  - not essential, but slowly start fixing indentation in scripts/lib
>  - git show -w is empty
> ---
>  scripts/lib/ptxd_lib_imx_hab.sh | 86 ++++++++++++++++-----------------
>  1 file changed, 43 insertions(+), 43 deletions(-)
> 
> diff --git a/scripts/lib/ptxd_lib_imx_hab.sh b/scripts/lib/ptxd_lib_imx_hab.sh
> index fa5b3e2c1439..7af2b1112855 100644
> --- a/scripts/lib/ptxd_lib_imx_hab.sh
> +++ b/scripts/lib/ptxd_lib_imx_hab.sh
> @@ -27,64 +27,64 @@
>  #     This will contain the srk hash which must be written to the fuses
>  #
>  ptxd_make_imx_habv4_gen_table_impl() {
> -    local group="${1}"
> -    local template="${1}"
> -    local srk_count="${2}"
> -    local table_bin="${pkg_build_dir}/imx-srk-table.bin"
> -    local srk_fuse_bin="${pkg_build_dir}/imx-srk-fuse.bin"
> -    local -a certs
> -    local i
> +	local group="${1}"
> +	local template="${1}"
> +	local srk_count="${2}"
> +	local table_bin="${pkg_build_dir}/imx-srk-table.bin"
> +	local srk_fuse_bin="${pkg_build_dir}/imx-srk-fuse.bin"
> +	local -a certs
> +	local i
>  
> -    case "${template}" in
> -	*%d*)	# <template> [<srk_count>]
> -	    if [ -z "${srk_count}" ]; then
> -		srk_count=4
> -	    fi
> +	case "${template}" in
> +		*%d*)	# <template> [<srk_count>]
> +			if [ -z "${srk_count}" ]; then
> +				srk_count=4
> +			fi
>  
> -	    if [ "${srk_count}" -gt 4 ]; then
> -		ptxd_bailout "HABv4 allows only 4 certificates"
> -	    fi
> +			if [ "${srk_count}" -gt 4 ]; then
> +				ptxd_bailout "HABv4 allows only 4 certificates"
> +			fi
>  
> -	    for i in $(seq ${srk_count}); do
> -		certs[${#certs[*]}]="$(cs_get_ca "$(printf "${template}" ${i})")"
> -	    done
> -	    ;;
> +			for i in $(seq ${srk_count}); do
> +				certs[${#certs[*]}]="$(cs_get_ca "$(printf "${template}" ${i})")"
> +			done
> +			;;
>  
> -	*)	# <role group>
> -	    local -a roles=( $(cs_group_get_roles "${group}") )
> +		*)	# <role group>
> +			local -a roles=( $(cs_group_get_roles "${group}") )
>  
> -	    if [ "${#roles[@]}" -eq 0 ]; then
> -		ptxd_bailout "Failed to get roles for group '${group}'"
> -	    fi
> +			if [ "${#roles[@]}" -eq 0 ]; then
> +				ptxd_bailout "Failed to get roles for group '${group}'"
> +			fi
>  
> -	    if [ "${#roles[@]}" -gt 4 ]; then
> -		ptxd_bailout "HABv4 allows only 4 certificates"
> -	    fi
> +			if [ "${#roles[@]}" -gt 4 ]; then
> +				ptxd_bailout "HABv4 allows only 4 certificates"
> +			fi
>  
> -	    for i in "${roles[@]}"; do
> -		certs[${#certs[*]}]="$(cs_get_ca "${i}")"
> -	    done
> -    esac
> +			for i in "${roles[@]}"; do
> +				certs[${#certs[*]}]="$(cs_get_ca "${i}")"
> +			done
> +	esac
>  
> -    echo -e "generating $(basename ${table_bin}) and $(basename ${srk_fuse_bin})\n"
> +	echo -e "generating $(basename ${table_bin}) and $(basename ${srk_fuse_bin})\n"
>  
> -    local orig_IFS="${IFS}"
> -    IFS=","
> -    certs="${certs[*]}"
> -    IFS="${orig_IFS}"
> +	local orig_IFS="${IFS}"
> +	IFS=","
> +	certs="${certs[*]}"
> +	IFS="${orig_IFS}"
>  
> -    ptxd_exec srktool --hab_ver 4 \
> -	--table "${table_bin}" \
> -	--efuses "${srk_fuse_bin}" \
> -	--digest sha256 \
> -	--certs "${certs}"
> +	ptxd_exec srktool --hab_ver 4 \
> +		--table "${table_bin}" \
> +		--efuses "${srk_fuse_bin}" \
> +		--digest sha256 \
> +		--certs "${certs}"
>  }
>  export -f ptxd_make_imx_habv4_gen_table_impl
>  
>  ptxd_make_imx_habv4_gen_table() {
> -    ptxd_make_world_init &&
> +	ptxd_make_world_init &&
>  
> -    ptxd_eval \
> +	ptxd_eval \
>  	"${pkg_make_env}" \
>  	ptxd_make_imx_habv4_gen_table_impl "${@}"
>  }
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de