From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 16 Jun 2021 15:12:33 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ltVLN-0000Ri-OV for lore@lore.pengutronix.de; Wed, 16 Jun 2021 15:12:33 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ltVLN-0001Kl-Cx; Wed, 16 Jun 2021 15:12:33 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltVLH-0001Kd-HU for ptxdist@pengutronix.de; Wed, 16 Jun 2021 15:12:27 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ltVLH-0006z0-85 for ptxdist@pengutronix.de; Wed, 16 Jun 2021 15:12:27 +0200 Date: Wed, 16 Jun 2021 15:12:27 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: <20210616131227.GM22020@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de References: <20210612204835.7372-1-rhi@pengutronix.de> <20210616114439.GK839947@pengutronix.de> <20210616125159.5oahcixic3qa6gjh@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210616125159.5oahcixic3qa6gjh@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:10:53 up 118 days, 16:34, 122 users, load average: 0.31, 0.24, 0.23 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] host-mtd-utils: build with crypto support X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Jun 16, 2021 at 02:51:59PM +0200, Roland Hieber wrote: > On Wed, Jun 16, 2021 at 01:44:39PM +0200, Michael Olbrich wrote: > > On Sat, Jun 12, 2021 at 10:48:35PM +0200, Roland Hieber wrote: > > > --with-crypto is needed e.g. for UBIFS Authentication support in > > > mkfs.ubifs, and the additional dependencies are negligible (and probably > > > even required for other host tools). > > > > That's not quite true. The problem with the host-kernel-header is that the > > default version comes from kernel version. So whenever the kernel version > > changes, anything depending on kernel headers is rebuilt. > > That's something I'd like to avoid. > > > > Also, for the UBIFS authentication, you need a special image anyways, > > right? So selecting HOST_MTD_UTILS_CRYPTO here would not be a problem. > > Ah right, a separate option for crypto support is also what I had > before, so I'll reintroduce it. > > > > > > Signed-off-by: Roland Hieber > > > --- > > > rules/host-mtd-utils.in | 2 ++ > > > rules/host-mtd-utils.make | 2 +- > > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/rules/host-mtd-utils.in b/rules/host-mtd-utils.in > > > index 4bdd554d94b1..25fd654e2b49 100644 > > > --- a/rules/host-mtd-utils.in > > > +++ b/rules/host-mtd-utils.in > > > @@ -6,4 +6,6 @@ config HOST_MTD_UTILS > > > select HOST_LIBLZO > > > select HOST_LIBUUID > > > select HOST_ZLIB > > > + select HOST_KERNEL_HEADER > > > > Why is this needed anyways? What is so new in the kernel headers that it's > > not available in most distributions? > > Hmmm yes, it might be that we selected the kernel headers because we > needed to support a few old Ubuntus in the BSP. I can try without. Add a comment if it is really needed. So we know why this is there. Michael > > > + select HOST_OPENSSL > > > default y if ALLYES > > > diff --git a/rules/host-mtd-utils.make b/rules/host-mtd-utils.make > > > index f49a08261781..20f30a7c7f42 100644 > > > --- a/rules/host-mtd-utils.make > > > +++ b/rules/host-mtd-utils.make > > > @@ -32,6 +32,6 @@ HOST_MTD_UTILS_CONF_OPT := \ > > > --with-lzo \ > > > --without-zstd \ > > > --without-selinux \ > > > - --without-crypto > > > + --with-crypto > > > > > > # vim: syntax=make > > > -- > > > 2.29.2 > > > > > > > > > _______________________________________________ > > > ptxdist mailing list > > > ptxdist@pengutronix.de > > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > > > > -- > > Pengutronix e.K. | | > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > > -- > Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de