Re: [ptxdist] [RFC PATCH 0/1] ppp: version bump 2.4.7 -> 2.4.9

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jun 16, 2021 at 02:22:01PM +0200, Alexander Dahl wrote:
> Am Wed, Jun 16, 2021 at 01:53:55PM +0200 schrieb Michael Olbrich:
> > Hi,
> > 
> > On Mon, Jun 14, 2021 at 04:47:54PM +0200, Alexander Dahl wrote:
> > > upstream released 2.4.7 in 2014 and 2.4.9 few months ago.  They use
> > > handcrafted 'configure' and 'Makefile', which makes cross-build and
> > > updating the package somewhat difficult.  For the new release upstream
> > > tried to improve cross-compile support (and continues to do so in git
> > > master branch).
> > > 
> > > This single patch series is RFC or WIP, because of several things:
> > > 
> > > - Importing debian patches was done manually, so the diff is probably
> > >   more noisy than necessary. Someone in IRC said there's a script for
> > >   that, but could not find it.
> > 
> > That's because it's not public yet. It's just something I hacked to
> > simplify this. I'll attach it to this mail. I should probably add it to
> > ptxdist, but it need some more polishing for that.
> > 
> > It doesn't do all the work for you. It just generates better formated
> > patches and has a blacklist for each package so we can avoid documentation
> > or debian specific patches more easily.
> 
> Thanks, I'll have a look into it.
> 
> > > - CFLAGS are not passed, and I don't know how to do that.
> > 
> > Maybe PPP_CFLAGS is what you need?
> > 
> > https://www.ptxdist.org/doc/ref_make_variables.html?highlight=_cflags#build-environment-for-all-stages
> 
> That's not what I meant. If I understand correctly, I can pass
> additional package specific CFLAGS with PPP_CFLAGS, which are added to
> other CFLAGS already set? If I don't touch that variable, it's not
> defined:
> 
>     % p print PPP_CFLAGS
>     PPP_CFLAGS undefined
> 
> What I need is something containing the CFLAGS already set by ptxdist
> through various variables (like platform hardening options) to pass it
> on to the handcrafted ./configure which does not consider the CFLAGS
> environment variable.

Why do you need to pass those to the configure script? All CFLAGS will be
automatically added when the compiler is called. Or is there some code in
the configure script that scans the CFLAGS manually?

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de