From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 16 Jun 2021 13:45:11 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ltTyp-00073V-5v for lore@lore.pengutronix.de; Wed, 16 Jun 2021 13:45:11 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ltTyo-0004b3-Pl; Wed, 16 Jun 2021 13:45:10 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltTyK-0004ao-EY; Wed, 16 Jun 2021 13:44:40 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ltTyJ-00023q-Uj; Wed, 16 Jun 2021 13:44:39 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1ltTyJ-00A66X-U7; Wed, 16 Jun 2021 13:44:39 +0200 Date: Wed, 16 Jun 2021 13:44:39 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: <20210616114439.GK839947@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de, Roland Hieber References: <20210612204835.7372-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210612204835.7372-1-rhi@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] host-mtd-utils: build with crypto support X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Roland Hieber Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sat, Jun 12, 2021 at 10:48:35PM +0200, Roland Hieber wrote: > --with-crypto is needed e.g. for UBIFS Authentication support in > mkfs.ubifs, and the additional dependencies are negligible (and probably > even required for other host tools). That's not quite true. The problem with the host-kernel-header is that the default version comes from kernel version. So whenever the kernel version changes, anything depending on kernel headers is rebuilt. That's something I'd like to avoid. Also, for the UBIFS authentication, you need a special image anyways, right? So selecting HOST_MTD_UTILS_CRYPTO here would not be a problem. > Signed-off-by: Roland Hieber > --- > rules/host-mtd-utils.in | 2 ++ > rules/host-mtd-utils.make | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/rules/host-mtd-utils.in b/rules/host-mtd-utils.in > index 4bdd554d94b1..25fd654e2b49 100644 > --- a/rules/host-mtd-utils.in > +++ b/rules/host-mtd-utils.in > @@ -6,4 +6,6 @@ config HOST_MTD_UTILS > select HOST_LIBLZO > select HOST_LIBUUID > select HOST_ZLIB > + select HOST_KERNEL_HEADER Why is this needed anyways? What is so new in the kernel headers that it's not available in most distributions? Michael > + select HOST_OPENSSL > default y if ALLYES > diff --git a/rules/host-mtd-utils.make b/rules/host-mtd-utils.make > index f49a08261781..20f30a7c7f42 100644 > --- a/rules/host-mtd-utils.make > +++ b/rules/host-mtd-utils.make > @@ -32,6 +32,6 @@ HOST_MTD_UTILS_CONF_OPT := \ > --with-lzo \ > --without-zstd \ > --without-selinux \ > - --without-crypto > + --with-crypto > > # vim: syntax=make > -- > 2.29.2 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de