Re: [ptxdist] [PATCH] host-mtd-utils: build with crypto support

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Jun 12, 2021 at 10:48:35PM +0200, Roland Hieber wrote:
> --with-crypto is needed e.g. for UBIFS Authentication support in
> mkfs.ubifs, and the additional dependencies are negligible (and probably
> even required for other host tools).

That's not quite true. The problem with the host-kernel-header is that the
default version comes from kernel version. So whenever the kernel version
changes, anything depending on kernel headers is rebuilt.
That's something I'd like to avoid.

Also, for the UBIFS authentication, you need a special image anyways,
right? So selecting HOST_MTD_UTILS_CRYPTO here would not be a problem.

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/host-mtd-utils.in   | 2 ++
>  rules/host-mtd-utils.make | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/host-mtd-utils.in b/rules/host-mtd-utils.in
> index 4bdd554d94b1..25fd654e2b49 100644
> --- a/rules/host-mtd-utils.in
> +++ b/rules/host-mtd-utils.in
> @@ -6,4 +6,6 @@ config HOST_MTD_UTILS
>  	select HOST_LIBLZO
>  	select HOST_LIBUUID
>  	select HOST_ZLIB
> +	select HOST_KERNEL_HEADER

Why is this needed anyways? What is so new in the kernel headers that it's
not available in most distributions?

Michael

> +	select HOST_OPENSSL
>  	default y if ALLYES
> diff --git a/rules/host-mtd-utils.make b/rules/host-mtd-utils.make
> index f49a08261781..20f30a7c7f42 100644
> --- a/rules/host-mtd-utils.make
> +++ b/rules/host-mtd-utils.make
> @@ -32,6 +32,6 @@ HOST_MTD_UTILS_CONF_OPT		:= \
>  	--with-lzo \
>  	--without-zstd \
>  	--without-selinux \
> -	--without-crypto
> +	--with-crypto
>  
>  # vim: syntax=make
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de