mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Felix Mellmann <flix.ptxdist@benfm.de>
Subject: Re: [ptxdist] [APPLIED] ifplugd: Added new patch to fix a linker error with GCC10
Date: Wed, 16 Jun 2021 12:35:03 +0200	[thread overview]
Message-ID: <20210616103503.1995369-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20210531132947.220277-2-flix.ptxdist@benfm.de>

Thanks, applied as 1e5fab0e2e79dd79d16385abcd3c9e6ec22a7917.

Michael

[sent from post-receive hook]

On Wed, 16 Jun 2021 12:35:03 +0200, Felix Mellmann <flix.ptxdist@benfm.de> wrote:
> Added a new patch to the ifplugd package which resolves a
> linker error when using GCC10.
> 
> Signed-off-by: Felix Mellmann <flix.ptxdist@benfm.de>
> Message-Id: <20210531132947.220277-2-flix.ptxdist@benfm.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/patches/ifplugd-0.28/0002-Fix-linker-error-when-using-GCC10.patch b/patches/ifplugd-0.28/0002-Fix-linker-error-when-using-GCC10.patch
> new file mode 100644
> index 000000000000..b1800d7c6517
> --- /dev/null
> +++ b/patches/ifplugd-0.28/0002-Fix-linker-error-when-using-GCC10.patch
> @@ -0,0 +1,28 @@
> +From: Felix Mellmann <flix.ptxdist@benfm.de>
> +Date: Mon, 31 May 2021 15:05:14 +0200
> +Subject: [PATCH] Fix linker error when using GCC10
> +
> +This patch fixes a linker error when using GCC10. Two
> +variables need to be marked as external to avoid multiple
> +definition.
> +
> +Signed-off-by: Felix Mellmann <flix.ptxdist@benfm.de>
> +---
> + src/interface.h | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/src/interface.h b/src/interface.h
> +index d223b1f5fabc..fd4a5f4cea63 100644
> +--- a/src/interface.h
> ++++ b/src/interface.h
> +@@ -21,8 +21,8 @@
> +  * Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
> +  */
> + 
> +-int interface_auto_up;
> +-int interface_do_message;
> ++extern int interface_auto_up;
> ++extern int interface_do_message;
> + 
> + typedef enum { IFSTATUS_UP, IFSTATUS_DOWN, IFSTATUS_ERR } interface_status_t;
> + 
> diff --git a/patches/ifplugd-0.28/series b/patches/ifplugd-0.28/series
> index a564ff7ddc85..1f8bb67d00ed 100644
> --- a/patches/ifplugd-0.28/series
> +++ b/patches/ifplugd-0.28/series
> @@ -1,4 +1,5 @@
>  # generated by git-ptx-patches
>  #tag:base --start-number 1
>  0001-Compilation-fails-because-of-kernel-header-inclusion.patch
> -# bbf895f48ef5cf6b103f60be48b437c9  - git-ptx-patches magic
> +0002-Fix-linker-error-when-using-GCC10.patch
> +# 5f6a3e3cf4117f7c3e207f9b9c45eb10  - git-ptx-patches magic

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-06-16 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 13:29 [ptxdist] [PATCH 1/2] ifplugd: Updated current patch set using git ptx-patches Felix Mellmann
2021-05-31 13:29 ` [ptxdist] [PATCH 2/2] ifplugd: Added new patch to fix a linker error with GCC10 Felix Mellmann
2021-06-16 10:35   ` Michael Olbrich [this message]
2021-06-16 10:35 ` [ptxdist] [APPLIED] ifplugd: Updated current patch set using git ptx-patches Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616103503.1995369-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=flix.ptxdist@benfm.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox