From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 11 Jun 2021 09:34:58 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lrbgw-0000yP-Ey for lore@lore.pengutronix.de; Fri, 11 Jun 2021 09:34:58 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lrbgw-0003xC-4E; Fri, 11 Jun 2021 09:34:58 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrbgF-0003wD-H6 for ptxdist@pengutronix.de; Fri, 11 Jun 2021 09:34:15 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lrbgE-0007T8-VO for ptxdist@pengutronix.de; Fri, 11 Jun 2021 09:34:14 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lrbgE-007Euc-SW for ptxdist@pengutronix.de; Fri, 11 Jun 2021 09:34:14 +0200 Date: Fri, 11 Jun 2021 09:34:14 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: <20210611073414.GB839947@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de References: <20210531141045.323134-1-flix.ptxdist@benfm.de> <20210604132723.zjqbqm3q6e32ww3i@pengutronix.de> <1380afdc-af64-dcbf-4f40-a4b6087a544d@benfm.de> <20210604180910.wog5mvkw5nk26yr3@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604180910.wog5mvkw5nk26yr3@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] f2fs-tools: version bump 1.12.0 -> 1.14.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Jun 04, 2021 at 08:09:10PM +0200, Roland Hieber wrote: > On Fri, Jun 04, 2021 at 07:12:16PM +0200, Felix Mellmann wrote: > > > > On 04.06.21 15:27, Roland Hieber wrote: > > > On Mon, May 31, 2021 at 04:10:45PM +0200, Felix Mellmann wrote: > > > > Bumped to version 1.14.0 and pinned license file. > > > > --- > > > > patches/{f2fs-tools-1.12.0 => f2fs-tools-1.14.0}/autogen.sh | 0 > > > > rules/f2fs-tools.make | 6 ++++-- > > > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > rename patches/{f2fs-tools-1.12.0 => f2fs-tools-1.14.0}/autogen.sh (100%) > > > > > > > > diff --git a/patches/f2fs-tools-1.12.0/autogen.sh b/patches/f2fs-tools-1.14.0/autogen.sh > > > > similarity index 100% > > > > rename from patches/f2fs-tools-1.12.0/autogen.sh > > > > rename to patches/f2fs-tools-1.14.0/autogen.sh > > > > diff --git a/rules/f2fs-tools.make b/rules/f2fs-tools.make > > > > index f37e9bdfc..7928580df 100644 > > > > --- a/rules/f2fs-tools.make > > > > +++ b/rules/f2fs-tools.make > > > > @@ -16,14 +16,16 @@ endif > > > > # > > > > # Paths and names > > > > # > > > > -F2FS_TOOLS_VERSION := 1.12.0 > > > > -F2FS_TOOLS_MD5 := 52d8ab4d6b6e7b8d416cb1c0da518fb0 > > > > +F2FS_TOOLS_VERSION := 1.14.0 > > > > +F2FS_TOOLS_MD5 := cd063630d3859fd5c03349e11f6b3e3e > > > > F2FS_TOOLS := f2fs-tools-$(F2FS_TOOLS_VERSION) > > > > F2FS_TOOLS_SUFFIX := tar.xz > > > > F2FS_TOOLS_URL := git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git;tag=v$(F2FS_TOOLS_VERSION) > > Would it be more suitable to use the official snapshots from https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/refs/tags > > ? Within our company the git protocol is blocked, http(s) can be accessed > > Yes, HTTPS URLs seems the best choice to me as long as we use the > official release tags anyway. Yet, the snapshot is better. Company firewalls are just one reason. Also, your patch is missing a Signed-off-by. Michael > > through a proxy. > > > > F2FS_TOOLS_SOURCE := $(SRCDIR)/$(F2FS_TOOLS).$(F2FS_TOOLS_SUFFIX) > > > > F2FS_TOOLS_DIR := $(BUILDDIR)/$(F2FS_TOOLS) > > > > F2FS_TOOLS_LICENSE := GPL-2.0-or-later LGPL-2.1-or-later > > > This should be "GPL-2.0-or-later AND LGPL-2.1-or-later", but other than > > > that > > > > > > Reviewed-by: Roland Hieber > > Forget about my last e-mail, I got your point now. Anyway, I try my best > > with the next patch ;) > > > > +F2FS_TOOLS_LICENSE_FILES := \ > > > > + file://COPYING;md5=362b4b2594cd362b874a97718faa51d3 > > > > # ---------------------------------------------------------------------------- > > > > # Prepare > > > > -- > > > > 2.25.1 > > -- > Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | > Steuerwalder Str. 21 | https://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de