mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] f2fs-tools: version bump 1.12.0 -> 1.14.0
Date: Fri, 11 Jun 2021 09:34:14 +0200	[thread overview]
Message-ID: <20210611073414.GB839947@pengutronix.de> (raw)
In-Reply-To: <20210604180910.wog5mvkw5nk26yr3@pengutronix.de>

On Fri, Jun 04, 2021 at 08:09:10PM +0200, Roland Hieber wrote:
> On Fri, Jun 04, 2021 at 07:12:16PM +0200, Felix Mellmann wrote:
> > 
> > On 04.06.21 15:27, Roland Hieber wrote:
> > > On Mon, May 31, 2021 at 04:10:45PM +0200, Felix Mellmann wrote:
> > > > Bumped to version 1.14.0 and pinned license file.
> > > > ---
> > > >   patches/{f2fs-tools-1.12.0 => f2fs-tools-1.14.0}/autogen.sh | 0
> > > >   rules/f2fs-tools.make                                       | 6 ++++--
> > > >   2 files changed, 4 insertions(+), 2 deletions(-)
> > > >   rename patches/{f2fs-tools-1.12.0 => f2fs-tools-1.14.0}/autogen.sh (100%)
> > > > 
> > > > diff --git a/patches/f2fs-tools-1.12.0/autogen.sh b/patches/f2fs-tools-1.14.0/autogen.sh
> > > > similarity index 100%
> > > > rename from patches/f2fs-tools-1.12.0/autogen.sh
> > > > rename to patches/f2fs-tools-1.14.0/autogen.sh
> > > > diff --git a/rules/f2fs-tools.make b/rules/f2fs-tools.make
> > > > index f37e9bdfc..7928580df 100644
> > > > --- a/rules/f2fs-tools.make
> > > > +++ b/rules/f2fs-tools.make
> > > > @@ -16,14 +16,16 @@ endif
> > > >   #
> > > >   # Paths and names
> > > >   #
> > > > -F2FS_TOOLS_VERSION	:= 1.12.0
> > > > -F2FS_TOOLS_MD5		:= 52d8ab4d6b6e7b8d416cb1c0da518fb0
> > > > +F2FS_TOOLS_VERSION	:= 1.14.0
> > > > +F2FS_TOOLS_MD5		:= cd063630d3859fd5c03349e11f6b3e3e
> > > >   F2FS_TOOLS		:= f2fs-tools-$(F2FS_TOOLS_VERSION)
> > > >   F2FS_TOOLS_SUFFIX	:= tar.xz
> > > >   F2FS_TOOLS_URL		:= git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git;tag=v$(F2FS_TOOLS_VERSION)
> > Would it be more suitable to use the official snapshots from https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/refs/tags
> > ? Within our company the git protocol is blocked, http(s) can be accessed
> 
> Yes, HTTPS URLs seems the best choice to me as long as we use the
> official release tags anyway.

Yet, the snapshot is better. Company firewalls are just one reason.

Also, your patch is missing a Signed-off-by.

Michael

> > through a proxy.
> > > >   F2FS_TOOLS_SOURCE	:= $(SRCDIR)/$(F2FS_TOOLS).$(F2FS_TOOLS_SUFFIX)
> > > >   F2FS_TOOLS_DIR		:= $(BUILDDIR)/$(F2FS_TOOLS)
> > > >   F2FS_TOOLS_LICENSE	:= GPL-2.0-or-later LGPL-2.1-or-later
> > > This should be "GPL-2.0-or-later AND LGPL-2.1-or-later", but other than
> > > that
> > > 
> > > Reviewed-by: Roland Hieber <rhi@pengutronix.de>
> > Forget about my last e-mail, I got your point now. Anyway, I try my best
> > with the next patch ;)
> > > > +F2FS_TOOLS_LICENSE_FILES := \
> > > > +	file://COPYING;md5=362b4b2594cd362b874a97718faa51d3
> > > >   # ----------------------------------------------------------------------------
> > > >   # Prepare
> > > > -- 
> > > > 2.25.1
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


      reply	other threads:[~2021-06-11  7:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 14:10 Felix Mellmann
2021-06-04 13:27 ` Roland Hieber
2021-06-04 17:09   ` Felix Mellmann
2021-06-04 17:12   ` Felix Mellmann
2021-06-04 18:09     ` Roland Hieber
2021-06-11  7:34       ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611073414.GB839947@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox