mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/3] chrony: enable support for PPS devices
Date: Fri, 4 Jun 2021 19:59:52 +0200	[thread overview]
Message-ID: <20210604175952.7hdtk6pmbhucz2ue@pengutronix.de> (raw)
In-Reply-To: <20210604092505.GF12506@pengutronix.de>

On Fri, Jun 04, 2021 at 11:25:05AM +0200, Michael Olbrich wrote:
> On Mon, May 31, 2021 at 01:57:07PM +0200, Roland Hieber wrote:
> > diff --git a/rules/chrony.make b/rules/chrony.make
> > index 7cf59f30560c..5edddf5b41a0 100644
> > --- a/rules/chrony.make
> > +++ b/rules/chrony.make
> > @@ -52,7 +52,7 @@ CHRONY_CONF_OPT		:= \
> >  	$(call ptx/ifdef, PTXCONF_CHRONY_ADVANCED_COMMAND,--enable-debug,) \
> >  	--disable-refclock \
> >  	--disable-phc \
> > -	--disable-pps \
> > +	$(call ptx/ifdef, PTXCONF_CHRONY_PPS_REFCLK,--enable-pps,--disable-pps) \
> 
> Use ptx/endis. Does this work? I think we use ptx/ifdef for the other
> options because e.g. --enable-ipv6 does not work as expected, so we only
> add the --disable-ipv6.

Mh no, the PPS option is equally broken as the others, and --enable-pps
does not work at all. It seems I've not tested this enough 😬

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-06-04 18:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 11:57 [ptxdist] [PATCH 1/3] pps-tools: new package Roland Hieber
2021-05-31 11:57 ` [ptxdist] [PATCH 2/3] chrony: enable support for PPS devices Roland Hieber
2021-06-04  9:25   ` Michael Olbrich
2021-06-04 17:59     ` Roland Hieber [this message]
2021-05-31 11:57 ` [ptxdist] [PATCH 3/3] chrony: fix typo Roland Hieber
2021-05-31 12:56 ` [ptxdist] [PATCH 1/3] pps-tools: new package Alexander Dahl
2021-05-31 12:58   ` Roland Hieber
2021-06-04  9:23 ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604175952.7hdtk6pmbhucz2ue@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox