mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>
Subject: [ptxdist] [PATCH] ptxd_colgen: propagate errors from ptxd_make_log
Date: Mon, 31 May 2021 08:53:16 +0200	[thread overview]
Message-ID: <20210531065316.808095-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20210529195036.rqt3kbnll4ggtsmc@pengutronix.de>

Actually abort if ptxd_make_log fails. Not only when awk fails.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---

On Sat, May 29, 2021 at 09:50:36PM +0200, Roland Hieber wrote:
> On Fri, May 28, 2021 at 07:09:26PM -0400, Jon Ringle wrote:
> > As I am updating bsp from 2020.10.0 to 2021.05.0, I noticed that the
> > collections now remove every package that I had previously marked to build
> > for the collection. How is this supposed to work now?
>·
> If one of those packages was gdb or gdbserver, that is probably only a
> follow-up error of your GDB version problem which you wrote about in
> your last thread.
>·
> (… I have the feeling that you're doing the same thing I was doing a few
> days ago, so let me try to answer your next question by giving you the
> hint that you forgot to replace KERNEL by KERNEL_PACKAGENAME when
> backporting commit 8484ecb7b244…)

And maybe try this first. It won't fix the underlying problem, but you
should get an error instread of the corrupted collection config.

Michael

 scripts/lib/ptxd_lib_colgen.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/lib/ptxd_lib_colgen.sh b/scripts/lib/ptxd_lib_colgen.sh
index e41e1913e64d..d3a4b0309114 100644
--- a/scripts/lib/ptxd_lib_colgen.sh
+++ b/scripts/lib/ptxd_lib_colgen.sh
@@ -76,6 +76,7 @@ ptxd_colgen_generate_sections()
 	"${PTX_MAP_ALL}" \
 	"${PTX_MAP_DEPS}" \
 	-
+    check_pipe_status
 }
 
 
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2021-05-31  6:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMwGMjyddc3N5a0fWds+2fJxxg9H_j7y0UyZcXubnSod0dCsGA@mail.gmail.com>
2021-05-29 19:50 ` [ptxdist] collections changed? Roland Hieber
2021-05-31  6:53   ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210531065316.808095-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox