From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v3] chrony: Fix location of config files
Date: Fri, 23 Apr 2021 09:43:31 +0200 [thread overview]
Message-ID: <20210423074331.GH4162561@pengutronix.de> (raw)
In-Reply-To: <CAH+2xPBzWQ7Sc6Cf4gAtHCWUrs7RgbW9VZ6UUachzpWrZRrPYw@mail.gmail.com>
On Fri, Apr 23, 2021 at 07:33:45AM +0200, Bruno Thomsen wrote:
> Den man. 19. apr. 2021 kl. 18.31 skrev Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de>:
> >
> > chrony uses /etc/chrony.conf since (at least) the start of its git history
> > in 2006.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> The old /etc/chrony/chrony.{conf,keys} locations are also in the help text
> in Kconfig (rules/chrony.in), but if that is also updated the patch looks good.
And the old locations are used in projectroot/etc/init.d/chrony. That needs
to be changed as well.
Michael
> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com>
>
> > ---
> > rules/chrony.make | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/rules/chrony.make b/rules/chrony.make
> > index 7cf59f30560c..49177e96fcb7 100644
> > --- a/rules/chrony.make
> > +++ b/rules/chrony.make
> > @@ -100,14 +100,14 @@ endif
> >
> > # generic one
> > ifdef PTXCONF_CHRONY_INSTALL_CONFIG
> > - @$(call install_alternative, chrony, 0, 0, 0644, /etc/chrony/chrony.conf)
> > - @$(call install_alternative, chrony, 0, 0, 0600, /etc/chrony/chrony.keys)
> > + @$(call install_alternative, chrony, 0, 0, 0644, /etc/chrony.conf)
> > + @$(call install_alternative, chrony, 0, 0, 0600, /etc/chrony.keys)
> >
> > # modify placeholders with data from configuration
> > - @$(call install_replace, chrony, /etc/chrony/chrony.conf, \
> > + @$(call install_replace, chrony, /etc/chrony.conf, \
> > @UNCONFIGURED_CHRONY_SERVER_IP@, $(PTXCONF_CHRONY_DEFAULT_NTP_SERVER))
> >
> > - @$(call install_replace, chrony, /etc/chrony/chrony.keys, \
> > + @$(call install_replace, chrony, /etc/chrony.keys, \
> > @UNCONFIGURED_CHRONY_ACCESS_KEY@, $(PTXCONF_CHRONY_DEFAULT_ACCESS_KEY))
> > endif
> >
> > --
> > 2.30.2
> >
> >
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2021-04-23 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 16:01 [ptxdist] [PATCH] " Uwe Kleine-König
2021-04-19 16:07 ` Roland Hieber
2021-04-19 16:10 ` [ptxdist] [PATCH v2] " Uwe Kleine-König
2021-04-19 16:30 ` [ptxdist] [PATCH v3] " Uwe Kleine-König
2021-04-23 5:33 ` Bruno Thomsen
2021-04-23 7:43 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423074331.GH4162561@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox