From: Roland Hieber <rhi@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v3 1/2] ptxd_make_vcs_version: add script to determine vcs hash
Date: Sun, 4 Apr 2021 19:16:40 +0200 [thread overview]
Message-ID: <20210404171640.j5lz6yw7wccxhlbm@pengutronix.de> (raw)
In-Reply-To: <20210401083641.9251-1-s.trumtrar@pengutronix.de>
On Thu, Apr 01, 2021 at 10:36:40AM +0200, Steffen Trumtrar wrote:
> Add a script to determine a uniquely abbreviated commit object of the
> current bsp state. The information is exported to the variable
> PTXDIST_VCS_VERSION so it can be used from other scripts and rules.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> changes in v3:
> - redirect stderr on second git call, too
> - fix PTXDIST_BUILD_VERSION_VCS -> PTXDIST_VCS_VERSION
> - fix whitespace on indent
>
> changes in v2:
> - use "--tags" in git describe
>
> scripts/lib/ptxd_make_vcs_version.sh | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 scripts/lib/ptxd_make_vcs_version.sh
>
> diff --git a/scripts/lib/ptxd_make_vcs_version.sh b/scripts/lib/ptxd_make_vcs_version.sh
> new file mode 100644
> index 000000000000..338658aa789f
> --- /dev/null
> +++ b/scripts/lib/ptxd_make_vcs_version.sh
> @@ -0,0 +1,22 @@
> +#!/bin/bash
> +#
> +# Copyright (C) 2020 by Steffen Trumtrar <s.trumtrar@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +ptxd_make_vcs_version() {
> + PTXDIST_VCS_VERSION="$(echo \
> + $(git describe 2>/dev/null || \
> + git describe --always --tags 2>/dev/null))"
Hmm, why do you do an additional echo here when git-describe already
outputs the thing?
- Roland
> +
> + if [ -z "${PTXDIST_VCS_VERSION}" ]; then
> + PTXDIST_VCS_VERSION="unknown"
> + fi
> +
> + export PTXDIST_VCS_VERSION
> +}
> +export -f ptxd_make_vcs_version
> +
> +ptxd_make_vcs_version
> --
> 2.29.2
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-04-04 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 8:36 Steffen Trumtrar
2021-04-01 8:36 ` [ptxdist] [PATCH v3 2/2] rules: barebox: support barebox buildsystem_version Steffen Trumtrar
2021-04-09 13:33 ` [ptxdist] [APPLIED] " Michael Olbrich
2021-04-04 17:16 ` Roland Hieber [this message]
2021-04-07 14:43 ` [ptxdist] [PATCH v3 1/2] ptxd_make_vcs_version: add script to determine vcs hash Michael Olbrich
2021-04-08 5:58 ` Steffen Trumtrar
2021-04-09 13:33 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210404171640.j5lz6yw7wccxhlbm@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox