From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [ptxdist] [PATCH v3] kernel: proper handle signed modules
Date: Thu, 1 Apr 2021 07:59:38 +0200 [thread overview]
Message-ID: <20210401055938.GJ8755@pengutronix.de> (raw)
In-Reply-To: <0bed7ba17cc82c39c5f46432b1309a7de0bc1491.camel@diehl.com>
On Wed, Mar 31, 2021 at 11:37:11AM +0000, Denis Osterland-Heim wrote:
> If CONFIG_MODULE_SIG_ALL is set in kernelconfig then modules will be
> automatically signed during the modules_install phase of a kernel build.
>
> Signed modules are BRITTLE as the signature is outside of the defined ELF
> container. Thus they MAY NOT be stripped once the signature is computed
> and attached. Note the entire module is the signed payload, including any
> and all debug information present at the time of signing.
>
> See: https://www.kernel.org/doc/html/latest/admin-guide/module-signing.html
> Signed-off-by: Denis Osterland-Heim <denis.osterland@diehl.com>
> ---
> v2 -> v3:
> - move TARGET_COMPILER_RECORD_SWITCHES to PTXDIST_LOWLEVEL_WRAPPER_BLACKLIST
Marc, what do you think?
>
> rules/kernel.make | 3 ++-
> rules/pre/kernel.make | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/rules/kernel.make b/rules/kernel.make
> index ea748fc8a..2b564612b 100644
> --- a/rules/kernel.make
> +++ b/rules/kernel.make
> @@ -61,6 +61,7 @@ KERNEL_BASE_OPT := \
> CROSS_COMPILE=$(KERNEL_CROSS_COMPILE) \
> DEPMOD=$(PTXDIST_SYSROOT_HOST)/sbin/depmod \
> \
> + INSTALL_MOD_STRIP=1 \
> INSTALL_MOD_PATH=$(KERNEL_PKGDIR) \
> PTX_KERNEL_DIR=$(KERNEL_DIR) \
> $(call remove_quotes,$(PTXCONF_KERNEL_EXTRA_MAKEVARS))
> @@ -313,7 +314,7 @@ ifdef PTXCONF_KERNEL_MODULES_INSTALL
> @$(call install_fixup, kernel-modules, AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
> @$(call install_fixup, kernel-modules, DESCRIPTION,missing)
>
> - @$(call install_glob, kernel-modules, 0, 0, -, /lib/modules, *.ko,, k)
> + @$(call install_glob, kernel-modules, 0, 0, -, /lib/modules, *.ko,, n)
We should do the same thing for the kernel template. But I'll take care of
that. There is some cleanup that I want to do anyways in that area.
Michael
> @$(call install_glob, kernel-modules, 0, 0, -, /lib/modules,, *.ko */build */source, n)
>
> @$(call install_finish, kernel-modules)
> diff --git a/rules/pre/kernel.make b/rules/pre/kernel.make
> index df53020aa..fb38d416d 100644
> --- a/rules/pre/kernel.make
> +++ b/rules/pre/kernel.make
> @@ -85,7 +85,8 @@ PTXDIST_LOWLEVEL_WRAPPER_BLACKLIST := \
> TARGET_HARDEN_PIE \
> TARGET_HARDEN_GLIBCXX_ASSERTIONS \
> TARGET_DEBUG \
> - TARGET_BUILD_ID
> + TARGET_BUILD_ID \
> + TARGET_COMPILER_RECORD_SWITCHES
>
> #
> # handle special compiler
> --
> 2.31.1
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2021-04-01 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 11:37 Denis Osterland-Heim
2021-04-01 5:59 ` Michael Olbrich [this message]
2021-04-01 6:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401055938.GJ8755@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=mkl@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox