mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH 2/2] rauc: be more verbose why the check for legacy keyring fails
Date: Mon,  1 Mar 2021 00:48:09 +0100	[thread overview]
Message-ID: <20210228234809.5294-2-rhi@pengutronix.de> (raw)
In-Reply-To: <20210228234809.5294-1-rhi@pengutronix.de>

Instead of relying on users to grep in the PTXdist source code for this
line, tell them directly what is checked here.

Also fix a typo in the previous-to-last line.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/rauc.make | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/rules/rauc.make b/rules/rauc.make
index 66c967d44b83..08df6336a7cd 100644
--- a/rules/rauc.make
+++ b/rules/rauc.make
@@ -50,8 +50,10 @@ RAUC_CONF_OPT	:= \
 
 $(STATEDIR)/rauc.prepare:
 	@$(call targetinfo)
-	@test ! -e "$(call ptx/in-platformconfigdir, config/rauc/rauc.key.pem)" || \
-		ptxd_bailout "Please use the signing provider infrastructure desribed in:" \
+	@keyfile="$(call ptx/in-platformconfigdir, config/rauc/rauc.key.pem)"; \
+		test ! -e "$${keyfile}" || \
+		ptxd_bailout "Legacy RAUC keyring exists at $${keyfile}!" \
+			"Please use the signing provider infrastructure instead, as described in:" \
 			"https://www.ptxdist.org/doc/dev_code_signing.html"
 	@$(call world/prepare, RAUC)
 	@$(call touch)
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-02-28 23:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 23:48 [ptxdist] [PATCH 1/2] doc: dev_code_signing: mention where to select the signing provider Roland Hieber
2021-02-28 23:48 ` Roland Hieber [this message]
2021-03-05  7:26   ` [ptxdist] [APPLIED] rauc: be more verbose why the check for legacy keyring fails Michael Olbrich
2021-03-05  7:26 ` [ptxdist] [APPLIED] doc: dev_code_signing: mention where to select the signing provider Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210228234809.5294-2-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox