mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] PTXCONF_KERNEL_GCC_PLUGINS broken with newer kernels
Date: Wed, 3 Feb 2021 11:54:35 +0100	[thread overview]
Message-ID: <20210203105435.GV19583@pengutronix.de> (raw)

In ptxdist we have the option PTXCONF_KERNEL_GCC_PLUGINS which is
described as:

| The kernel kconfig options to enable gcc plugins depend on a
| sufficiently new host compiler. As a result, the kernel config
| may change with a different host compiler version.
| If this option is disabled then the environment is manipulated
| to ensure that the compiler check always fails. This keeps the
| kernel config stable. Enable this option when the kernel gcc
| plugins are used.

This stopped working with this kernel commit:

| commit 1e860048c53ee77ee9870dcce94847a28544b753
| Author: Masahiro Yamada <masahiroy@kernel.org>
| Date:   Thu Dec 3 21:57:00 2020 +0900
| 
|     gcc-plugins: simplify GCC plugin-dev capability test

This commit changed the test in a way that it always succeeds, no matter
if PTXCONF_KERNEL_GCC_PLUGINS is set or not:

-       depends on $(success,$(srctree)/scripts/gcc-plugin.sh $(CC))
+       depends on $(success,test -e $(shell,$(CC) -print-file-name=plugin)/include/plugin-version.h)

What indeed still fails is compilation of the plugins when
PTXCONF_KERNEL_GCC_PLUGINS is unset. So in a way this option still does
its job, you won't get a kernel with plugins enabled, but instead you
get a terrifying error message during compilation of the kernel.

I am unsure what we want to do about this, so this is merely a heads up
for now.

Sascha



-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

                 reply	other threads:[~2021-02-03 10:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203105435.GV19583@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox