Re: [ptxdist] [PATCH] rootfs: Fix handling of empty variables

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Feb 03, 2021 at 08:23:42AM +0100, Sascha Hauer wrote:
> On Wed, Feb 03, 2021 at 08:10:59AM +0100, Michael Olbrich wrote:
> > On Tue, Feb 02, 2021 at 03:58:36PM +0100, Sascha Hauer wrote:
> > > $(PTXCONF_PROJECT_VENDOR) and $(PTXCONF_ROOTFS_ETC_HOSTNAME) can be
> > > empty variables in which case bash answers with:
> > > 
> > > /bin/bash: command substitution: line 0: syntax error near unexpected token `newline'
> > > /bin/bash: command substitution: line 0: `sed -r 's/ ?([\.:;,]) ?/ \1 /' <<< '
> > 
> > This is strange. Why are these variables empty? They are strings in
> > kconfig. The resulting make variables should include the quotes, so they
> > should never be empty.
> 
> To be correct PTXCONF_ROOTFS_ETC_HOSTNAME is not empty, it's just not
> defined. That is because ROOTFS_ETC_HOSTNAME depends on ROOTFS_HOSTNAME
> which in my case is set to 'n'.
> 
> I guess PTXCONF_PROJECT_VENDOR will indeed always have quotes as this
> variable doesn't depend on another variable. We could drop this hunk, I
> added it for consistency.

Ah, no I see it. Then it should be:

	`... <<< "$(call remove_quotes,$(PTXCONF_ROOTFS_ETC_HOSTNAME))"`

So, remove the quotes if they are there and always add them.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de