From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Wed, 3 Feb 2021 08:23:42 +0100
From: Sascha Hauer <s.hauer@pengutronix.de>
Message-ID: <20210203072342.GS19583@pengutronix.de>
References: <20210202145836.28983-1-s.hauer@pengutronix.de>
 <20210203071059.GJ5577@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20210203071059.GJ5577@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] rootfs: Fix handling of empty variables
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: ptxdist@pengutronix.de

On Wed, Feb 03, 2021 at 08:10:59AM +0100, Michael Olbrich wrote:
> On Tue, Feb 02, 2021 at 03:58:36PM +0100, Sascha Hauer wrote:
> > $(PTXCONF_PROJECT_VENDOR) and $(PTXCONF_ROOTFS_ETC_HOSTNAME) can be
> > empty variables in which case bash answers with:
> > 
> > /bin/bash: command substitution: line 0: syntax error near unexpected token `newline'
> > /bin/bash: command substitution: line 0: `sed -r 's/ ?([\.:;,]) ?/ \1 /' <<< '
> 
> This is strange. Why are these variables empty? They are strings in
> kconfig. The resulting make variables should include the quotes, so they
> should never be empty.

To be correct PTXCONF_ROOTFS_ETC_HOSTNAME is not empty, it's just not
defined. That is because ROOTFS_ETC_HOSTNAME depends on ROOTFS_HOSTNAME
which in my case is set to 'n'.

I guess PTXCONF_PROJECT_VENDOR will indeed always have quotes as this
variable doesn't depend on another variable. We could drop this hunk, I
added it for consistency.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de