From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Sun, 24 Jan 2021 16:42:49 +0100 From: Roland Hieber Message-ID: <20210124154249.elcsohi65vmxj2mf@pengutronix.de> References: <20210124111804.510632-1-flix.ptxdist@benfm.de> <20210124130824.7ubx4yilejyrgahw@falbala.internal.home.lespocky.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [ptxdist] [PATCH] Added symbolic links to the midnight commander package which allows to call the viewer, the editor and the diff tool from the command line. List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Felix Mellmann Cc: ptxdist@pengutronix.de On Sun, Jan 24, 2021 at 02:31:54PM +0100, Felix Mellmann wrote: > Hello Alex, > > I'm sorry that I've missed to obey the line length. Since I have never > made any contribution to any mailing list until now, I think I have to > learn a lot. I'm also unsure if my other two contributions have even > reached the mailing list as only your answer is visible... Yes, they reached the mailing list. You can find them in the archive: One of your mails didn't have a subject, and it looks like it should have been the commit message of the patch you sent before. When using git-send-email, you send every commit as a single patch. The first line of your commit message is used as the subject line for the mail, and the other lines of the commit messages, followed by the diff content, are the body of the message. Therefore it is convention to format the commit message like you would write a plain-text e-mail and use hard line breaks after 72 characters. Also, for PTXdist, the usual pattern for subject lines is starting with the packages name followed by a colon. In your case, a good concise subject would be "mc: install symlinks for mcedit, mcdiff, mcview". Some more pointers for using git-send-email: If you send multiple patches that depend on each other, it is common to send them as a mail thread. You can use git-send-email's --thread argument followed by the commit IDs (or a commit range) to send all of them them at once (this should already be the default behaviour of git-send-email). When the maintainer uses git-am on your mails to apply them to their branch, the commit message will stay intact like you sent them. However, if you want to give more information to the reviewers that should not be part of the commit message when applying the patch, you can add them below a "---" line. This is often used to give a changelog when sending multiple iterations of a patch. See for example [1], which was applied in master as [2]. [1]: https://www.mail-archive.com/ptxdist@pengutronix.de/msg17493.html [2]: https://git.pengutronix.de/cgit/ptxdist/commit/?id=b5515256f0b1c49c28a2 When sending the next iteration of your patch(es) after incorporating any feedback you got, send the complete thread again, and use the -v option for git-send-email, e.g. -v2, -v3, -v4 and so on. This will change the subject into "[PATCH v2]" etc. so it is clear that the patch was changed. Also give a changelog what you changed in relation to the first iteration, like described above. You can also use --cover-letter to describe your patch series as a whole (and the changelog for follow-up iterations) in a separate mail, which will not be committed to the Git repository. See [3] for such an example. [3]: https://www.mail-archive.com/ptxdist@pengutronix.de/msg17481.html - Roland _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de