From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.126.130]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3f83-0007o8-Hg for ptxdist@pengutronix.de; Sun, 24 Jan 2021 14:08:35 +0100 Date: Sun, 24 Jan 2021 14:08:24 +0100 From: Alexander Dahl Message-ID: <20210124130824.7ubx4yilejyrgahw@falbala.internal.home.lespocky.de> References: <20210124111804.510632-1-flix.ptxdist@benfm.de> MIME-Version: 1.0 In-Reply-To: <20210124111804.510632-1-flix.ptxdist@benfm.de> Subject: Re: [ptxdist] [PATCH] Added symbolic links to the midnight commander package which allows to call the viewer, the editor and the diff tool from the command line. List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: multipart/mixed; boundary="===============1362890029==" Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: Felix Mellmann Cc: ptxdist@pengutronix.de --===============1362890029== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="l26ecnbgvqdoucjc" Content-Disposition: inline --l26ecnbgvqdoucjc Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Felix, On Sun, Jan 24, 2021 at 12:18:05PM +0100, Felix Mellmann wrote: > The midnight commander allows to call internal tools by using their aprop= riate > name. By adding symbolic links these tool are accessible from the command= line. > Some users may appreciate using i.e. mcedit directly without the need to = start > a midnight commander. >=20 > Signed-off-by: Felix Mellmann > --- > rules/mc.make | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/rules/mc.make b/rules/mc.make > index 67fc61690..9335e9d0b 100644 > --- a/rules/mc.make > +++ b/rules/mc.make > @@ -71,6 +71,10 @@ $(STATEDIR)/mc.targetinstall: > @$(call install_fixup, mc,DESCRIPTION,missing) > =20 > @$(call install_copy, mc, 0, 0, 0755, -, /usr/bin/mc) > + @$(call install_link, mc, mc, /usr/bin/mcdiff) > + @$(call install_link, mc, mc, /usr/bin/mcedit) > + @$(call install_link, mc, mc, /usr/bin/mcview) > + > @$(call install_alternative_tree, mc, 0, 0, /etc/mc) > @$(call install_tree, mc, 0, 0, -, /usr/share/mc/skins) This is certainly a valuable improvement. However, please trim down the first line of the commit message to 60, at most 80 chars. This is common practice and good style when working with Git. Thanks and greets Alex --=20 /"\ ASCII RIBBON | =BBWith the first link, the chain is forged. The first \ / CAMPAIGN | speech censured, the first thought forbidden, the X AGAINST | first freedom denied, chains us all irrevocably.=AB / \ HTML MAIL | (Jean-Luc Picard, quoting Judge Aaron Satie) --l26ecnbgvqdoucjc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEwo7muQJjlc+Prwj6NK3NAHIhXMYFAmANcUQACgkQNK3NAHIh XMbDdhAAkY1XSXKpdL6Hskc2v4NhOx6KzUaIHt2KTt2c26xBIG3aSu3ydtQYUt0o f4rUnf2VX1JdIv32rWLA1Sn1LvFrVzSHtde2AVf6/h6pmdteeOxAEcZZj8XQF8wC wpCRnpXRkvCnvR0epM3Yzjbs/E9DRiVkA7lsbtl3J6iWr/cIGgyiDrfeKiP+VZgX ycPs3jYhBOY3J2L1eigS/P6e5VbOEMe25T8Q623Hwp4Z7j1iKumPX/5NLgiLOLG0 UYGaosaejKI8Ag0Ztg48CUIx7NgxHqHwhIFVc/U0ecphoYBaCOmbgp2qzS3hK+Zb FT0Wwc8mo/+NwJsgl1t+XlOSbJ7qI4Tz/PtzIeJ/i3FFACaa3qAwaHgM57LxAS47 TcBBzf/3T68IPfHFEonLK4OXA2exr6GDeiDOFMwEOpLfbmAWBfrlnb1piS12dmZL KpGWKA+ZRpyuW+zNmO2NERQBBEN2Ley2nm13V4JcSwuJyS7ihnDd6rRJnq8ci0U0 M/38rHaAQnm1uJuTVTUiuJ/HNsODlIzRUHsO6hxR+exJq3B2QLWgPY/VOBqk4uC+ pu0LMxepPJs8Ne05T6TsGOppCDHvr3m+YC7IxuHBNLzaImepzyF73aFEGIsik9zY Ds3w1YbHpZL6ztS8shUA/1Wa4/cpF3W59qqSp3Ex83y5VpAHpQc= =st4y -----END PGP SIGNATURE----- --l26ecnbgvqdoucjc-- --===============1362890029== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de --===============1362890029==--