mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [ptxdist] [PATCH] ptxd_make_image_common: optionally install debug packages into rootfs
Date: Thu, 14 Jan 2021 23:50:49 +0100	[thread overview]
Message-ID: <20210114225049.1634-1-rhi@pengutronix.de> (raw)

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 rules/00debug-packages.in             | 12 ++++++++++++
 scripts/lib/ptxd_make_image_common.sh |  9 +++++++++
 2 files changed, 21 insertions(+)

diff --git a/rules/00debug-packages.in b/rules/00debug-packages.in
index 64dd254f15e9..1e3ea0f4837b 100644
--- a/rules/00debug-packages.in
+++ b/rules/00debug-packages.in
@@ -10,3 +10,15 @@ config DEBUG_PACKAGES
 	  are otherwise only available in nfsroot.
 	  This is useful to run debug tools such as gdb, valgrind, perf
 	  etc. on a normal (not nfsroot) rootfs.
+
+config DEBUG_PACKAGES_INSTALL
+	bool
+	select DEBUG_PACKAGES
+	prompt "install debug packages into rootfs"
+	help
+	  Include debug symbols of all packages that are installed into the root
+	  filesystem. This is needed if you want to run gdb, valgrind, etc. on
+	  the target.
+
+	  Debug symbols can take a certain amount of disk space, make sure your
+	  root file system is big enough.
diff --git a/scripts/lib/ptxd_make_image_common.sh b/scripts/lib/ptxd_make_image_common.sh
index 1170226aed70..551420080669 100644
--- a/scripts/lib/ptxd_make_image_common.sh
+++ b/scripts/lib/ptxd_make_image_common.sh
@@ -48,6 +48,15 @@ Run first 'ptxdist clean root' then 'ptxdist images' again.
 "
 	fi
 
+	if ptxd_get_ptxconf PTXCONF_DEBUG_PACKAGES_INSTALL > /dev/null; then
+	    # some packages don't install binaries, so they don't have dbgsyms.
+	    # don't complain about that.
+	    ipkg_files="${image_ipkg_repo_dirs[@]/%//${1}-dbgsym_*.ipk}"
+	    if ptxd_get_path ${ipkg_files[*]}; then
+		ptxd_reply_ipkg_files[${#ptxd_reply_ipkg_files[@]}]="${ptxd_reply}"
+	    fi
+	fi
+
 	shift
     done
 }
-- 
2.30.0


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

             reply	other threads:[~2021-01-14 22:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 22:50 Roland Hieber [this message]
2021-01-15 11:18 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114225049.1634-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox