Hello Michael,

thanks for your review. See below.

On Fri, Nov 13, 2020 at 11:26:01AM +0100, Michael Olbrich wrote:
> On Fri, Nov 06, 2020 at 07:58:11AM +0100, Alexander Dahl wrote:
> > Changes in LICENSE file:
> > 
> > - updated copyright years
> > - pointed to licenses of bundled libs, instead of just stating their
> >   license
> > 
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> 
> Hmmm, with PTXCONF_DROPBEAR_BLOWFISH=y building fails with:
> 
> crypto_desc.c: In function 'crypto_init':
> crypto_desc.c:28:4: error: 'blowfish_desc' undeclared (first use in this function); did you mean 'twofish_desc'?
> crypto_desc.c:28:4: note: each undeclared identifier is reported only once for each function it appears in

IIRC dropbear removed blowfish support in one of the last releases. I
have to dig through the changelogs again. This option should be
removed. I'll send a new iteration of the patch series. Maybe I also
remove the DES and MD5 options on the way.

Alex

> 
> Michael
> 
> > ---
> >  rules/dropbear.make | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/rules/dropbear.make b/rules/dropbear.make
> > index 1907bc0ae..47fed4938 100644
> > --- a/rules/dropbear.make
> > +++ b/rules/dropbear.make
> > @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_DROPBEAR) += dropbear
> >  #
> >  # Paths and names
> >  #
> > -DROPBEAR_VERSION	:= 2020.79
> > -DROPBEAR_MD5		:= 830a7bf6349ac52a39c487d061efb352
> > +DROPBEAR_VERSION	:= 2020.81
> > +DROPBEAR_MD5		:= a07438a6159a24c61f98f1bce2d479c0
> >  DROPBEAR		:= dropbear-$(DROPBEAR_VERSION)
> >  DROPBEAR_SUFFIX		:= tar.bz2
> >  DROPBEAR_URL		:= http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR_SUFFIX)
> > @@ -26,7 +26,7 @@ DROPBEAR_DIR		:= $(BUILDDIR)/$(DROPBEAR)
> >  DROPBEAR_LICENSE	:= \
> >  	MIT AND BSD-2-Clause AND public_domain AND SSH-short AND (public_domain OR WTFPL) AND Unlicense
> >  DROPBEAR_LICENSE_FILES	:= \
> > -	file://LICENSE;md5=da58928b5d844c6667963cb5a109272d \
> > +	file://LICENSE;md5=25cf44512b7bc8966a48b6b1a9b7605f \
> >  	file://libtomcrypt/LICENSE;md5=71baacc459522324ef3e2b9e052e8180 \
> >  	file://libtommath/LICENSE;md5=23e7e0a32e53a2b1d35f5fd9ef053402 \
> >  	file://loginrec.c;startline=1;endline=26;md5=0d785ee11fab1cead2c7fee9c35574f1
> > -- 
> > 2.27.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)