mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <post@lespocky.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 4/4] dropbear: version bump 2020.79 -> 2020.81
Date: Fri, 13 Nov 2020 14:28:04 +0100	[thread overview]
Message-ID: <20201113132803.ji7yak3jqxyl3nye@falbala.internal.home.lespocky.de> (raw)
In-Reply-To: <20201113102601.GA16869@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 3058 bytes --]

Hello Michael,

thanks for your review. See below.

On Fri, Nov 13, 2020 at 11:26:01AM +0100, Michael Olbrich wrote:
> On Fri, Nov 06, 2020 at 07:58:11AM +0100, Alexander Dahl wrote:
> > Changes in LICENSE file:
> > 
> > - updated copyright years
> > - pointed to licenses of bundled libs, instead of just stating their
> >   license
> > 
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> 
> Hmmm, with PTXCONF_DROPBEAR_BLOWFISH=y building fails with:
> 
> crypto_desc.c: In function 'crypto_init':
> crypto_desc.c:28:4: error: 'blowfish_desc' undeclared (first use in this function); did you mean 'twofish_desc'?
> crypto_desc.c:28:4: note: each undeclared identifier is reported only once for each function it appears in

IIRC dropbear removed blowfish support in one of the last releases. I
have to dig through the changelogs again. This option should be
removed. I'll send a new iteration of the patch series. Maybe I also
remove the DES and MD5 options on the way.

Alex

> 
> Michael
> 
> > ---
> >  rules/dropbear.make | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/rules/dropbear.make b/rules/dropbear.make
> > index 1907bc0ae..47fed4938 100644
> > --- a/rules/dropbear.make
> > +++ b/rules/dropbear.make
> > @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_DROPBEAR) += dropbear
> >  #
> >  # Paths and names
> >  #
> > -DROPBEAR_VERSION	:= 2020.79
> > -DROPBEAR_MD5		:= 830a7bf6349ac52a39c487d061efb352
> > +DROPBEAR_VERSION	:= 2020.81
> > +DROPBEAR_MD5		:= a07438a6159a24c61f98f1bce2d479c0
> >  DROPBEAR		:= dropbear-$(DROPBEAR_VERSION)
> >  DROPBEAR_SUFFIX		:= tar.bz2
> >  DROPBEAR_URL		:= http://matt.ucc.asn.au/dropbear/releases/$(DROPBEAR).$(DROPBEAR_SUFFIX)
> > @@ -26,7 +26,7 @@ DROPBEAR_DIR		:= $(BUILDDIR)/$(DROPBEAR)
> >  DROPBEAR_LICENSE	:= \
> >  	MIT AND BSD-2-Clause AND public_domain AND SSH-short AND (public_domain OR WTFPL) AND Unlicense
> >  DROPBEAR_LICENSE_FILES	:= \
> > -	file://LICENSE;md5=da58928b5d844c6667963cb5a109272d \
> > +	file://LICENSE;md5=25cf44512b7bc8966a48b6b1a9b7605f \
> >  	file://libtomcrypt/LICENSE;md5=71baacc459522324ef3e2b9e052e8180 \
> >  	file://libtommath/LICENSE;md5=23e7e0a32e53a2b1d35f5fd9ef053402 \
> >  	file://loginrec.c;startline=1;endline=26;md5=0d785ee11fab1cead2c7fee9c35574f1
> > -- 
> > 2.27.0
> > 
> > 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

-- 
/"\ ASCII RIBBON | »With the first link, the chain is forged. The first
\ / CAMPAIGN     | speech censured, the first thought forbidden, the
 X  AGAINST      | first freedom denied, chains us all irrevocably.«
/ \ HTML MAIL    | (Jean-Luc Picard, quoting Judge Aaron Satie)

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2020-11-13 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06  6:58 [ptxdist] [PATCH v2 0/4] dropbear: version bump 2019.78 " Alexander Dahl
2020-11-06  6:58 ` [ptxdist] [PATCH v2 1/4] dropbear: Consider licenses of bundled libs Alexander Dahl
2020-11-06  6:58 ` [ptxdist] [PATCH v2 2/4] dropbear: Revise comments Alexander Dahl
2020-11-13  8:32   ` Michael Olbrich
2020-11-06  6:58 ` [ptxdist] [PATCH v2 3/4] dropbear: version bump 2019.78 -> 2020.79 Alexander Dahl
2020-11-06  6:58 ` [ptxdist] [PATCH v2 4/4] dropbear: version bump 2020.79 -> 2020.81 Alexander Dahl
2020-11-13 10:26   ` Michael Olbrich
2020-11-13 13:28     ` Alexander Dahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113132803.ji7yak3jqxyl3nye@falbala.internal.home.lespocky.de \
    --to=post@lespocky.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox