Re: [ptxdist] [PATCH 3/3] wpewebkit: version bump 2.28.4 -> 2.30.1

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Oct 07, 2020 at 01:37:19PM +0200, Bastian Krause wrote:
> ENABLE_ACCELERATED_2D_CANVAS=ON is broken on 2.30.1. It defaults to off
> and does not really improve performance on embedded devices
> (paraphrasing the wpewebkit maintainers). There was even discussion to
> turn it into a private option [1]. So turn it off.
> 
> wpewebkit depends on gstreamer for audio/video playback and more.
> The required plugin packages are already selected, but not all plugins
> used in Source/WebCore/platform/{audio,graphics,mediastream}/.
> Fix that.

I think we should have options for audio and video and select the relevant
packages and plugins conditionally.
And while you're at it: I'm guessing that for GST_PLUGINS_GOOD1 a runtime
dependency only is sufficient, but that needs testing.

Michael

> [1] https://bugs.webkit.org/show_bug.cgi?id=148473
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
>  rules/wpewebkit.in   | 26 +++++++++++++++++++++++++-
>  rules/wpewebkit.make |  9 ++++++---
>  2 files changed, 31 insertions(+), 4 deletions(-)
> 
> diff --git a/rules/wpewebkit.in b/rules/wpewebkit.in
> index d91758406..c0e0d3570 100644
> --- a/rules/wpewebkit.in
> +++ b/rules/wpewebkit.in
> @@ -40,13 +40,31 @@ menuconfig WPEWEBKIT
>  	select GSTREAMER1
>  	select GST_PLUGINS_BASE1
>  	select GST_PLUGINS_BASE1_APP
> -	select GST_PLUGINS_BASE1_GL
> +	select GST_PLUGINS_BASE1_AUDIOCONVERT
> +	select GST_PLUGINS_BASE1_AUDIOMIXER
> +	select GST_PLUGINS_BASE1_AUDIORESAMPLE
>  	select GST_PLUGINS_BASE1_EGL
> +	select GST_PLUGINS_BASE1_GIO
> +	select GST_PLUGINS_BASE1_GL
> +	select GST_PLUGINS_BASE1_PLAYBACK
> +	select GST_PLUGINS_BASE1_VIDEOCONVERT
> +	select GST_PLUGINS_BASE1_VOLUME
>  	select GST_PLUGINS_GOOD1
> +	select GST_PLUGINS_GOOD1_AUDIOFX
> +	select GST_PLUGINS_GOOD1_AUTODETECT
> +	select GST_PLUGINS_GOOD1_INTERLEAVE
> +	select GST_PLUGINS_GOOD1_ISOMP4
> +	select GST_PLUGINS_GOOD1_MATROSKA
> +	select GST_PLUGINS_GOOD1_VIDEOFILTER
>  	select GST_PLUGINS_BAD1
> +	select GST_PLUGINS_BAD1_DEBUGUTILS
> +	select GST_PLUGINS_BAD1_OPUS
> +	select GST_PLUGINS_BAD1_SUBENC
> +	select GST_PLUGINS_BAD1_VIDEOPARSERS
>  	select WPEBACKEND_FDO
>  	select QT5			if WPEWEBKIT_QT
>  	select QT5_MODULE_QTDECLARATIVE	if WPEWEBKIT_QT
> +	select SYSTEMD			if WPEWEBKIT_JOURNALD
>  	help
>  	  WebPlatformForEmbedded port for the WebKit cross-platform web browser engine.
>  
> @@ -56,4 +74,10 @@ config WPEWEBKIT_QT
>  	bool
>  	prompt "Qt API"
>  
> +config WPEWEBKIT_JOURNALD
> +	bool
> +	depends on INITMETHOD_SYSTEMD
> +	default y
> +	prompt "journald support"
> +
>  endif
> diff --git a/rules/wpewebkit.make b/rules/wpewebkit.make
> index c0007d777..470e004f7 100644
> --- a/rules/wpewebkit.make
> +++ b/rules/wpewebkit.make
> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_WPEWEBKIT) += wpewebkit
>  #
>  # Paths and names
>  #
> -WPEWEBKIT_VERSION	:= 2.28.4
> -WPEWEBKIT_MD5		:= 6ab041f6ebdb2e053981de5980c864e7
> +WPEWEBKIT_VERSION	:= 2.30.1
> +WPEWEBKIT_MD5		:= 251228a6e2917eff90a3eb6e9a7e920d
>  WPEWEBKIT		:= wpewebkit-$(WPEWEBKIT_VERSION)
>  WPEWEBKIT_SUFFIX	:= tar.xz
>  WPEWEBKIT_URL		:= https://wpewebkit.org/releases/$(WPEWEBKIT).$(WPEWEBKIT_SUFFIX)
> @@ -35,8 +35,9 @@ WPEWEBKIT_CONF_OPT	:= \
>  	$(CROSS_CMAKE_USR) \
>  	-G Ninja \
>  	-DCMAKE_BUILD_TYPE=Release \
> +	-DANALYZERS=OFF \
>  	-DDEBUG_FISSION=OFF \
> -	-DENABLE_ACCELERATED_2D_CANVAS=ON \
> +	-DENABLE_ACCELERATED_2D_CANVAS=OFF \
>  	-DENABLE_ACCESSIBILITY=OFF \
>  	-DENABLE_BUBBLEWRAP_SANDBOX=OFF \
>  	-DENABLE_ENCRYPTED_MEDIA=OFF \
> @@ -49,11 +50,13 @@ WPEWEBKIT_CONF_OPT	:= \
>  	-DENABLE_WEB_CRYPTO=ON \
>  	-DENABLE_WPE_QT_API=$(call ptx/onoff,PTXCONF_WPEWEBKIT_QT) \
>  	-DENABLE_XSLT=ON \
> +	-DGCC_OFFLINEASM_SOURCE_MAP=OFF \
>  	-DPORT=WPE \
>  	-DSHOULD_INSTALL_JS_SHELL=OFF \
>  	-DSHOW_BINDINGS_GENERATION_PROGRESS=ON \
>  	-DUSE_LD_GOLD=OFF \
>  	-DUSE_OPENJPEG=OFF \
> +	-DUSE_SYSTEMD=$(call ptx/onoff,PTXCONF_WPEWEBKIT_JOURNALD) \
>  	-DUSE_THIN_ARCHIVES=ON \
>  	-DUSE_WOFF2=OFF \
>  	-DWTF_CPU_ARM64_CORTEXA53=OFF
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de