[ptxdist] [PATCH] rootfs: Fix creation of the /media directory

[ptxdist] [PATCH] rootfs: Fix creation of the /media directory

[Gavin Schenk]

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

The directory /media is created depending on PTXCONF_ROOTFS_MEDIA only.

On our read-only system we mount a tmpfs on /media, so that we can
dynamically create additional mount points. With PTXCONF_ROOTFS_MEDIA set,
but none of PTXCONF_ROOTFS_MEDIA[1-6], the /media directory was not created
and mounting failed.

fixes: 63e2d8696124083fc
Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
---
 rules/rootfs.make | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/rootfs.make b/rules/rootfs.make
index 6b37db5bd..419ca001e 100644
--- a/rules/rootfs.make
+++ b/rules/rootfs.make
@@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
        @$(call install_copy, rootfs, 0, 0, 0700, /root)
 endif
 ifdef PTXCONF_ROOTFS_MEDIA
+       @$(call install_copy, rootfs, 0, 0, 0755, /media)
 ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
        @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
 endif
--
2.28.0

Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de


[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] rootfs: Fix creation of the /media directory

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 1067 bytes --]

Hallo Gavin,

On Mon, Oct 05, 2020 at 11:16:16AM +0200, Gavin Schenk wrote:
> The directory /media is created depending on PTXCONF_ROOTFS_MEDIA only.

I'd write:

	Ensure that with PTXCONF_ROOTFS_MEDIA set /media is created even
	if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.

(Is that what you intended to say?)

> On our read-only system we mount a tmpfs on /media, so that we can
> dynamically create additional mount points. With PTXCONF_ROOTFS_MEDIA set,
> but none of PTXCONF_ROOTFS_MEDIA[1-6], the /media directory was not created
> and mounting failed.
> 
> fixes: 63e2d8696124083fc

The usual format here (at least in the kernel) is:

	Fixes: 63e2d8696124 ("rootfs: don't create empty /media subdirs")

(I have in my ~/.gitconfig:

	[alias]
        oneq = show -s --pretty='format:%h (\"%s\")'

for that.)

Other than that the change looks good.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

[ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Gavin Schenk]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.

On our read-only system we mount a tmpfs on directory '/media' in order
to dynamically create additional mount points there.

Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
---

Hi Uwe,

thank you for the feedback, this is my V2.
I have a new alias in my .gitconfig :-)

Regards
Gavin

 rules/rootfs.make | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/rootfs.make b/rules/rootfs.make
index 6b37db5bd..419ca001e 100644
--- a/rules/rootfs.make
+++ b/rules/rootfs.make
@@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
        @$(call install_copy, rootfs, 0, 0, 0700, /root)
 endif
 ifdef PTXCONF_ROOTFS_MEDIA
+       @$(call install_copy, rootfs, 0, 0, 0755, /media)
 ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
        @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
 endif
--
2.28.0

Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de


[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Denis Osterland-Heim]

Hi,

Am Montag, den 05.10.2020, 13:10 +0200 schrieb Gavin Schenk:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
>
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
>
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
Sounds like your "fix" is a change of intended behavior.
I suggest to create this folder in the package,
in which you install your mount logic (the dynamic creation).
This keeps the status quo for the rest of ptxdist installations,
where /media is not needed.

Regards, Denis

> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
>
> Hi Uwe,
>
> thank you for the feedback, this is my V2.
> I have a new alias in my .gitconfig :-)
>
> Regards
> Gavin
>
>  rules/rootfs.make | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 6b37db5bd..419ca001e 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
>         @$(call install_copy, rootfs, 0, 0, 0700, /root)
>  endif
>  ifdef PTXCONF_ROOTFS_MEDIA
> +       @$(call install_copy, rootfs, 0, 0, 0755, /media)
>  ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
>         @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
>  endif
> --
> 2.28.0
>
> Eckelmann AG
> Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> Dr.-Ing. Marco Mnchhof Dr.-Ing. Frank Uhlemann
> Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> http://www.eckelmann.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Gavin Schenk]

Hi Denis,

> Am Montag, den 05.10.2020, 13:10 +0200 schrieb Gavin Schenk:
> > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> >
> > On our read-only system we mount a tmpfs on directory '/media' in order
> > to dynamically create additional mount points there.
> >
> > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Sounds like your "fix" is a change of intended behavior.

what is the intended behavior of PTXCONF_ROOTFS_MEDIA besides creating a
folder /media which is not always the case without this patch?

> I suggest to create this folder in the package,
> in which you install your mount logic (the dynamic creation).

Yes that would be a possible alternative if this patch is rejected.

> This keeps the status quo for the rest of ptxdist installations,
> where /media is not needed.
>

If /media is not needed you can just unset PTXCONF_ROOTFS_MEDIA.
With this change the semantic equals to e.g. PTXCONF_ROOTFS_HOME, where the
intended behaviour is creating directory /home, in my opinion.

Regards
Gavin
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Denis Osterland-Heim]

Hi,

Am Montag, den 05.10.2020, 14:02 +0200 schrieb Gavin Schenk:
> Hi Denis,
>
> > Am Montag, den 05.10.2020, 13:10 +0200 schrieb Gavin Schenk:
> > > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> > >
> > > On our read-only system we mount a tmpfs on directory '/media' in order
> > > to dynamically create additional mount points there.
> > >
> > > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> >
> > Sounds like your "fix" is a change of intended behavior.
>
> what is the intended behavior of PTXCONF_ROOTFS_MEDIA besides creating a
> folder /media which is not always the case without this patch?
You are right. I got it wrong.
If ROOTFS_MEDIA is set, I would expect a /media folder as well.

Regards, Denis

>
> > I suggest to create this folder in the package,
> > in which you install your mount logic (the dynamic creation).
>
> Yes that would be a possible alternative if this patch is rejected.
>
> > This keeps the status quo for the rest of ptxdist installations,
> > where /media is not needed.
> >
>
> If /media is not needed you can just unset PTXCONF_ROOTFS_MEDIA.
> With this change the semantic equals to e.g. PTXCONF_ROOTFS_HOME, where the
> intended behaviour is creating directory /home, in my opinion.
>
> Regards
> Gavin
> Eckelmann AG
> Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
> Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> http://www.eckelmann.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315

________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.

- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter:

https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.

- For general information on data protection and your respective rights please visit:

https://www.diehl.com/group/en/transparency-and-information-obligations/


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Michael Olbrich]

On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> 
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
> 
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
> 
> Hi Uwe,
> 
> thank you for the feedback, this is my V2.
> I have a new alias in my .gitconfig :-)
> 
> Regards
> Gavin
> 
>  rules/rootfs.make | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 6b37db5bd..419ca001e 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
>         @$(call install_copy, rootfs, 0, 0, 0700, /root)
>  endif
>  ifdef PTXCONF_ROOTFS_MEDIA
> +       @$(call install_copy, rootfs, 0, 0, 0755, /media)

Your email client broke the whitespaces.

Michael

>  ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
>         @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
>  endif
> --
> 2.28.0
> 
> Eckelmann AG
> Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann
> Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> http://www.eckelmann.de
> 

> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Ladislav Michl]

Hi,

On Wed, Oct 07, 2020 at 09:28:40AM +0200, Michael Olbrich wrote:
> On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote:
> > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> > 
> > On our read-only system we mount a tmpfs on directory '/media' in order
> > to dynamically create additional mount points there.
> > 
> > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> > Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> > ---
> > 
> > Hi Uwe,
> > 
> > thank you for the feedback, this is my V2.
> > I have a new alias in my .gitconfig :-)
> > 
> > Regards
> > Gavin
> > 
> >  rules/rootfs.make | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/rootfs.make b/rules/rootfs.make
> > index 6b37db5bd..419ca001e 100644
> > --- a/rules/rootfs.make
> > +++ b/rules/rootfs.make
> > @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
> >         @$(call install_copy, rootfs, 0, 0, 0700, /root)
> >  endif
> >  ifdef PTXCONF_ROOTFS_MEDIA
> > +       @$(call install_copy, rootfs, 0, 0, 0755, /media)
> 
> Your email client broke the whitespaces.

Gavin, please resend, my setup mounts tmpfs over /media as well.
Michael, in case no resend appears, could you fix manually. I'd like to see
it in 2020.10.0 as it could be a release I do not need to patch
after long time (finally).

Thanks in advance to both of you.

> Michael
> 
> >  ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
> >         @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
> >  endif
> > --
> > 2.28.0
> > 
> > Eckelmann AG
> > Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> > Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann
> > Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> > Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> > http://www.eckelmann.de
> > 
> 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de