From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eddie.linux-mips.org ([148.251.95.138] helo=cvs.linux-mips.org) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1kQEYI-000706-3M for ptxdist@pengutronix.de; Wed, 07 Oct 2020 20:52:38 +0200 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23990434AbgJGSwfhfNfd (ORCPT ); Wed, 7 Oct 2020 20:52:35 +0200 Date: Wed, 7 Oct 2020 20:52:34 +0200 From: Ladislav Michl Message-ID: <20201007185234.GA844333@lenoch> References: <20201005091616.1281120-1-g.schenk@eckelmann.de> <20201005111035.1642881-1-g.schenk@eckelmann.de> <20201007072840.GS11021@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201007072840.GS11021@pengutronix.de> Subject: Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de, Gavin Schenk Hi, On Wed, Oct 07, 2020 at 09:28:40AM +0200, Michael Olbrich wrote: > On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote: > > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created > > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set. > > > > On our read-only system we mount a tmpfs on directory '/media' in order > > to dynamically create additional mount points there. > > > > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs) > > Signed-off-by: Gavin Schenk > > --- > > > > Hi Uwe, > > > > thank you for the feedback, this is my V2. > > I have a new alias in my .gitconfig :-) > > > > Regards > > Gavin > > > > rules/rootfs.make | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rules/rootfs.make b/rules/rootfs.make > > index 6b37db5bd..419ca001e 100644 > > --- a/rules/rootfs.make > > +++ b/rules/rootfs.make > > @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT > > @$(call install_copy, rootfs, 0, 0, 0700, /root) > > endif > > ifdef PTXCONF_ROOTFS_MEDIA > > + @$(call install_copy, rootfs, 0, 0, 0755, /media) > > Your email client broke the whitespaces. Gavin, please resend, my setup mounts tmpfs over /media as well. Michael, in case no resend appears, could you fix manually. I'd like to see it in 2020.10.0 as it could be a release I do not need to patch after long time (finally). Thanks in advance to both of you. > Michael > > > ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),) > > @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1)) > > endif > > -- > > 2.28.0 > > > > Eckelmann AG > > Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann > > Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann > > Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann > > Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636 > > http://www.eckelmann.de > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de