Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory

[Ladislav Michl <ladis@linux-mips.org>]

Hi,

On Wed, Oct 07, 2020 at 09:28:40AM +0200, Michael Olbrich wrote:
> On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote:
> > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> > 
> > On our read-only system we mount a tmpfs on directory '/media' in order
> > to dynamically create additional mount points there.
> > 
> > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> > Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> > ---
> > 
> > Hi Uwe,
> > 
> > thank you for the feedback, this is my V2.
> > I have a new alias in my .gitconfig :-)
> > 
> > Regards
> > Gavin
> > 
> >  rules/rootfs.make | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/rootfs.make b/rules/rootfs.make
> > index 6b37db5bd..419ca001e 100644
> > --- a/rules/rootfs.make
> > +++ b/rules/rootfs.make
> > @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
> >         @$(call install_copy, rootfs, 0, 0, 0700, /root)
> >  endif
> >  ifdef PTXCONF_ROOTFS_MEDIA
> > +       @$(call install_copy, rootfs, 0, 0, 0755, /media)
> 
> Your email client broke the whitespaces.

Gavin, please resend, my setup mounts tmpfs over /media as well.
Michael, in case no resend appears, could you fix manually. I'd like to see
it in 2020.10.0 as it could be a release I do not need to patch
after long time (finally).

Thanks in advance to both of you.

> Michael
> 
> >  ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
> >         @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
> >  endif
> > --
> > 2.28.0
> > 
> > Eckelmann AG
> > Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> > Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann
> > Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> > Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> > http://www.eckelmann.de
> > 
> 
> > _______________________________________________
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de