From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Wed, 7 Oct 2020 09:28:40 +0200 From: Michael Olbrich Message-ID: <20201007072840.GS11021@pengutronix.de> References: <20201005091616.1281120-1-g.schenk@eckelmann.de> <20201005111035.1642881-1-g.schenk@eckelmann.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201005111035.1642881-1-g.schenk@eckelmann.de> Subject: Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de Cc: Gavin Schenk On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote: > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set. > > On our read-only system we mount a tmpfs on directory '/media' in order > to dynamically create additional mount points there. > > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs) > Signed-off-by: Gavin Schenk > --- > > Hi Uwe, > > thank you for the feedback, this is my V2. > I have a new alias in my .gitconfig :-) > > Regards > Gavin > > rules/rootfs.make | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rules/rootfs.make b/rules/rootfs.make > index 6b37db5bd..419ca001e 100644 > --- a/rules/rootfs.make > +++ b/rules/rootfs.make > @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT > @$(call install_copy, rootfs, 0, 0, 0700, /root) > endif > ifdef PTXCONF_ROOTFS_MEDIA > + @$(call install_copy, rootfs, 0, 0, 0755, /media) Your email client broke the whitespaces. Michael > ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),) > @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1)) > endif > -- > 2.28.0 > > Eckelmann AG > Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann > Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann > Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann > Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636 > http://www.eckelmann.de > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de