From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Gavin Schenk <g.schenk@eckelmann.de>
Subject: Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory
Date: Wed, 7 Oct 2020 09:28:40 +0200 [thread overview]
Message-ID: <20201007072840.GS11021@pengutronix.de> (raw)
In-Reply-To: <20201005111035.1642881-1-g.schenk@eckelmann.de>
On Mon, Oct 05, 2020 at 01:10:35PM +0200, Gavin Schenk wrote:
> Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
>
> On our read-only system we mount a tmpfs on directory '/media' in order
> to dynamically create additional mount points there.
>
> Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Signed-off-by: Gavin Schenk <g.schenk@eckelmann.de>
> ---
>
> Hi Uwe,
>
> thank you for the feedback, this is my V2.
> I have a new alias in my .gitconfig :-)
>
> Regards
> Gavin
>
> rules/rootfs.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rules/rootfs.make b/rules/rootfs.make
> index 6b37db5bd..419ca001e 100644
> --- a/rules/rootfs.make
> +++ b/rules/rootfs.make
> @@ -63,6 +63,7 @@ ifdef PTXCONF_ROOTFS_HOME_ROOT
> @$(call install_copy, rootfs, 0, 0, 0700, /root)
> endif
> ifdef PTXCONF_ROOTFS_MEDIA
> + @$(call install_copy, rootfs, 0, 0, 0755, /media)
Your email client broke the whitespaces.
Michael
> ifneq ($(call remove_quotes,$(PTXCONF_ROOTFS_MEDIA1)),)
> @$(call install_copy, rootfs, 0, 0, 0777, /media/$(PTXCONF_ROOTFS_MEDIA1))
> endif
> --
> 2.28.0
>
> Eckelmann AG
> Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
> Dr.-Ing. Marco M?nchhof Dr.-Ing. Frank Uhlemann
> Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
> Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
> http://www.eckelmann.de
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-10-07 7:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 9:16 [ptxdist] [PATCH] " Gavin Schenk
2020-10-05 9:50 ` Uwe Kleine-König
2020-10-05 11:10 ` [ptxdist] [PATCH v2] " Gavin Schenk
2020-10-05 11:38 ` Denis Osterland-Heim
2020-10-05 12:02 ` Gavin Schenk
2020-10-05 12:36 ` Denis Osterland-Heim
2020-10-07 7:28 ` Michael Olbrich [this message]
2020-10-07 18:52 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007072840.GS11021@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=g.schenk@eckelmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox