From: Gavin Schenk <g.schenk@eckelmann.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] rootfs: Fix creation of the /media directory
Date: Mon, 5 Oct 2020 14:02:13 +0200 [thread overview]
Message-ID: <20201005120213.csf7bbhxeaiak4ya@NB061.eckelmann.group> (raw)
In-Reply-To: <0fbf023879354ebb86e089f73e9a28ed417138a7.camel@diehl.com>
Hi Denis,
> Am Montag, den 05.10.2020, 13:10 +0200 schrieb Gavin Schenk:
> > Ensure that with PTXCONF_ROOTFS_MEDIA set directory '/media' is created
> > even if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
> >
> > On our read-only system we mount a tmpfs on directory '/media' in order
> > to dynamically create additional mount points there.
> >
> > Fixes: 63e2d8696 (rootfs: don't create empty /media subdirs)
> Sounds like your "fix" is a change of intended behavior.
what is the intended behavior of PTXCONF_ROOTFS_MEDIA besides creating a
folder /media which is not always the case without this patch?
> I suggest to create this folder in the package,
> in which you install your mount logic (the dynamic creation).
Yes that would be a possible alternative if this patch is rejected.
> This keeps the status quo for the rest of ptxdist installations,
> where /media is not needed.
>
If /media is not needed you can just unset PTXCONF_ROOTFS_MEDIA.
With this change the semantic equals to e.g. PTXCONF_ROOTFS_HOME, where the
intended behaviour is creating directory /home, in my opinion.
Regards
Gavin
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-10-05 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 9:16 [ptxdist] [PATCH] " Gavin Schenk
2020-10-05 9:50 ` Uwe Kleine-König
2020-10-05 11:10 ` [ptxdist] [PATCH v2] " Gavin Schenk
2020-10-05 11:38 ` Denis Osterland-Heim
2020-10-05 12:02 ` Gavin Schenk [this message]
2020-10-05 12:36 ` Denis Osterland-Heim
2020-10-07 7:28 ` Michael Olbrich
2020-10-07 18:52 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005120213.csf7bbhxeaiak4ya@NB061.eckelmann.group \
--to=g.schenk@eckelmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox