From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Mon, 5 Oct 2020 11:50:32 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Message-ID: <20201005095032.skvga4qm6fbhw45l@pengutronix.de>
References: <20201005091616.1281120-1-g.schenk@eckelmann.de>
MIME-Version: 1.0
In-Reply-To: <20201005091616.1281120-1-g.schenk@eckelmann.de>
Subject: Re: [ptxdist] [PATCH] rootfs: Fix creation of the /media directory
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: multipart/mixed; boundary="===============0575404131=="
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: Gavin Schenk <g.schenk@eckelmann.de>
Cc: ptxdist@pengutronix.de


--===============0575404131==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="afqpgo6lqyoo3jdz"
Content-Disposition: inline


--afqpgo6lqyoo3jdz
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hallo Gavin,

On Mon, Oct 05, 2020 at 11:16:16AM +0200, Gavin Schenk wrote:
> The directory /media is created depending on PTXCONF_ROOTFS_MEDIA only.

I'd write:

	Ensure that with PTXCONF_ROOTFS_MEDIA set /media is created even
	if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.

(Is that what you intended to say?)

> On our read-only system we mount a tmpfs on /media, so that we can
> dynamically create additional mount points. With PTXCONF_ROOTFS_MEDIA set,
> but none of PTXCONF_ROOTFS_MEDIA[1-6], the /media directory was not creat=
ed
> and mounting failed.
>=20
> fixes: 63e2d8696124083fc

The usual format here (at least in the kernel) is:

	Fixes: 63e2d8696124 ("rootfs: don't create empty /media subdirs")

(I have in my ~/.gitconfig:

	[alias]
        oneq =3D show -s --pretty=3D'format:%h (\"%s\")'

for that.)

Other than that the change looks good.

Best regards
Uwe


--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--afqpgo6lqyoo3jdz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl967GUACgkQwfwUeK3K
7AlqqggAhZNLJs8Sy+hPOD6eFHBOApln6Rr55e8mwexxqwP3MrRBINdicxJcdP7X
/XACWv0PMJ3IRcFC9tTf67r9bIQ4BxV+LKBCR3o6Hwu6lzUs6I+1tzd5TGJDgeSY
pyF0GZ+KqGPTFRN/qDzbfR6HtgCXkCecwekshicsjCMogWFvXRfgUugzgZgb+Khg
mh56Di1IUW3yLaNRNBTuu3Dme5prevOMFsXXeHvU+4b4sOQ5WBkwFBW1SuBl3Z0j
LpHtlYf1bQrpbxVuUG2bQAo8JgBmbUGAPlPjr4zoZMhMd099dOW065TUNx95+3vj
DAGkEDs2vzdJQVnFps6QNvNChEfn3g==
=y2YO
-----END PGP SIGNATURE-----

--afqpgo6lqyoo3jdz--


--===============0575404131==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

--===============0575404131==--