Hallo Gavin,

On Mon, Oct 05, 2020 at 11:16:16AM +0200, Gavin Schenk wrote:
> The directory /media is created depending on PTXCONF_ROOTFS_MEDIA only.

I'd write:

	Ensure that with PTXCONF_ROOTFS_MEDIA set /media is created even
	if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.

(Is that what you intended to say?)

> On our read-only system we mount a tmpfs on /media, so that we can
> dynamically create additional mount points. With PTXCONF_ROOTFS_MEDIA set,
> but none of PTXCONF_ROOTFS_MEDIA[1-6], the /media directory was not created
> and mounting failed.
> 
> fixes: 63e2d8696124083fc

The usual format here (at least in the kernel) is:

	Fixes: 63e2d8696124 ("rootfs: don't create empty /media subdirs")

(I have in my ~/.gitconfig:

	[alias]
        oneq = show -s --pretty='format:%h (\"%s\")'

for that.)

Other than that the change looks good.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |