From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Gavin Schenk <g.schenk@eckelmann.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] rootfs: Fix creation of the /media directory
Date: Mon, 5 Oct 2020 11:50:32 +0200 [thread overview]
Message-ID: <20201005095032.skvga4qm6fbhw45l@pengutronix.de> (raw)
In-Reply-To: <20201005091616.1281120-1-g.schenk@eckelmann.de>
[-- Attachment #1.1: Type: text/plain, Size: 1067 bytes --]
Hallo Gavin,
On Mon, Oct 05, 2020 at 11:16:16AM +0200, Gavin Schenk wrote:
> The directory /media is created depending on PTXCONF_ROOTFS_MEDIA only.
I'd write:
Ensure that with PTXCONF_ROOTFS_MEDIA set /media is created even
if none of PTXCONF_ROOTFS_MEDIA[1-6] is set.
(Is that what you intended to say?)
> On our read-only system we mount a tmpfs on /media, so that we can
> dynamically create additional mount points. With PTXCONF_ROOTFS_MEDIA set,
> but none of PTXCONF_ROOTFS_MEDIA[1-6], the /media directory was not created
> and mounting failed.
>
> fixes: 63e2d8696124083fc
The usual format here (at least in the kernel) is:
Fixes: 63e2d8696124 ("rootfs: don't create empty /media subdirs")
(I have in my ~/.gitconfig:
[alias]
oneq = show -s --pretty='format:%h (\"%s\")'
for that.)
Other than that the change looks good.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-10-05 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 9:16 Gavin Schenk
2020-10-05 9:50 ` Uwe Kleine-König [this message]
2020-10-05 11:10 ` [ptxdist] [PATCH v2] " Gavin Schenk
2020-10-05 11:38 ` Denis Osterland-Heim
2020-10-05 12:02 ` Gavin Schenk
2020-10-05 12:36 ` Denis Osterland-Heim
2020-10-07 7:28 ` Michael Olbrich
2020-10-07 18:52 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005095032.skvga4qm6fbhw45l@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=g.schenk@eckelmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox