Re: [ptxdist] [PATCH 7/7] ptxdist: add 'init' commands to create new configs

[Roland Hieber <rhi@pengutronix.de>]

On Thu, Sep 24, 2020 at 03:42:18PM +0200, Michael Olbrich wrote:
> On Wed, Sep 23, 2020 at 02:22:59PM +0200, Roland Hieber wrote:
> > On Tue, Sep 22, 2020 at 11:46:22AM +0200, Michael Olbrich wrote:
> > > On Tue, Sep 22, 2020 at 12:17:28AM +0200, Roland Hieber wrote:
[...]
> > > > +# PTXCONF_KERNEL_CONFIG_BASE_VERSION is not set
> > > > +PTXCONF_KERNEL_SERIES="series"
> > > > +PTXCONF_KERNEL_CONFIG="kernelconfig-${PTXCONF_KERNEL_VERSION}"
> > > 
> > > I thought I changed that default. Please change this and the default value
> > > to just "kernelconfig". The version just causes problems in most cases.
> > 
> > Oh, right. I remember a discussion about it.

I've sent a separate patch for this in <20200927214336.23382-1-rhi@pengutronix.de>
since this series needs some more thought.

[...]
> > > > +endchoice
> > > > diff --git a/rules/init_defconfig b/rules/init_defconfig
> > > > new file mode 100644
> > > > index 000000000000..9fa9ab00a60b
> > > > --- /dev/null
> > > > +++ b/rules/init_defconfig
> > > > @@ -0,0 +1,21 @@
> > > > +# PTXCONF_ALLYES is not set
> > > > +# PTXCONF_BROKEN is not set
> > > > +PTXCONF_FIX_PERMISSIONS=y
> > > > +PTXCONF_PROJECT_VERSION="-${PTXDIST_BSP_AUTOVERSION}"
> > > > +# PTXCONF_PROJECT_CREATE_DEVPKGS is not set
> > > > +# PTXCONF_PROJECT_USE_DEVPKGS is not set
> > > > +PTXCONF_PROJECT_DEVPKGDIR=""
> > > > +PTXCONF_PROJECT_DEVMIRROR=""
> > > > +# PTXCONF_PROJECT_CHECK_LICENSES is not set
> > > > +PTXCONF_REPRODUCIBLE_TIMESTAMP_PTXDIST=y
> > > > +# PTXCONF_REPRODUCIBLE_TIMESTAMP_TOOLCHAIN is not set
> > > > +# PTXCONF_REPRODUCIBLE_TIMESTAMP_CUSTOM is not set
> > > > +# PTXCONF_REPRODUCIBLE_TIMESTAMP_STRING is not set
> > > > +PTXCONF_DEBUG_PACKAGES=y
> > > > +# initmethod will enable the following busybox tools if needed:
> > > > +# PTXCONF_BUSYBOX_HALT is not set
> > > > +# PTXCONF_BUSYBOX_INIT is not set
> > > > +# PTXCONF_BUSYBOX_POWEROFF is not set
> > > > +# PTXCONF_BUSYBOX_REBOOT is not set
> > > > +# PTXCONF_BUSYBOX_RUNLEVEL is not set
> > > > +# PTXCONF_STAGING is not set
> > > 
> > > How can we keep these files up-to-date?
> > 
> > I guess like for everything else: patches or bug reports if someone
> > notices that it's broken. And the only way it can break will just lead
> > to more unnecessary questions being asked, which is a bit annoying but
> > not a tragedy, or defaults from the Kconfig options being used, which
> > should be fine.
> 
> This just helps for new options, not old ones. Those just pile up.
> 
> > Alternatively I think kconfig has a "save_defconfig" function which
> > could help us.
> 
> The problem is that we want to provide defaults only for some of the
> options.

I think I'll solve this problem differently in v3. Since the other
patches are unrelated to this one, if you don't have anything else
against them, feel free to apply them already.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de