Re: [ptxdist] [PATCH] tf-a: Allow to build for multiple platforms

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Sep 25, 2020 at 08:11:02AM +0200, Sascha Hauer wrote:
> On Thu, Sep 24, 2020 at 03:55:33PM +0200, Michael Olbrich wrote:
> > On Thu, Sep 24, 2020 at 11:31:24AM +0200, Sascha Hauer wrote:
> > > A single ptxdist build can be for multiple platforms, so allow to
> > > compile the ARM trusted firmware for multiple platforms as well.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > ---
> > >  platforms/tf-a.in |  6 +++---
> > >  rules/tf-a.make   | 28 ++++++++++++++++++----------
> > >  2 files changed, 21 insertions(+), 13 deletions(-)
> > > 
> > > diff --git a/platforms/tf-a.in b/platforms/tf-a.in
> > > index ba04f44be..0936319f1 100644
> > > --- a/platforms/tf-a.in
> > > +++ b/platforms/tf-a.in
> > > @@ -58,11 +58,11 @@ config TF_A_ARM_ARCH_MAJOR
> > >          default 8 if TF_A_ARM_ARCH_MAJOR_8
> > >  
> > >  
> > > -config TF_A_PLATFORM
> > > +config TF_A_PLATFORMS
> > 
> > Please add a migration helper for this in scripts/migrate/migrate_platform.
> 
> Is this worth the hassle? I could also keep the old name instead.

I prefer the new name. It's less confusing in the long run.

Michael

> > > -TF_A_BUILD_OUTPUT_DIR	:= $(TF_A_BUILDDIR)/$(TF_A_PLATFORM)/release
> > > -TF_A_ARTIFACTS_SRC	 = $(wildcard $(addprefix $(TF_A_BUILD_OUTPUT_DIR)/,$(TF_A_ARTIFACTS)))
> > > +inst_plat = $(foreach artifact, \
> > > +	$(wildcard $(TF_A_BUILDDIR)/$(1)/release/$(TF_A_ARTIFACTS)), \
> > > +	install -v -D -m 644 $(artifact) \
> > > +		$(2)/$(1)-$(notdir $(artifact))$(ptx/nl))
> > > +
> > > +inst_bins = $(foreach plat, $(TF_A_PLATFORMS), $(call inst_plat,$(plat),$(1)))
> > 
> > These should be namespaced to avoid name clashes. Maybe
> > 
> > tf-a/inst_plat = ...
> > tf-a/inst_bins = ...
> 
> OK
> 
> Sascha
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de