From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKeHb-00089v-Ss for ptxdist@pengutronix.de; Tue, 22 Sep 2020 11:08:19 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kKeHb-0006nf-Ja for ptxdist@pengutronix.de; Tue, 22 Sep 2020 11:08:19 +0200 Date: Tue, 22 Sep 2020 11:08:19 +0200 From: Roland Hieber Message-ID: <20200922090819.mieuk3rwstgu2xbd@pengutronix.de> References: <20200921221728.3229-1-rhi@pengutronix.de> <20200921221728.3229-4-rhi@pengutronix.de> <20200922081743.GE11021@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922081743.GE11021@pengutronix.de> Subject: Re: [ptxdist] [PATCH 4/7] image-root-tgz: build by default, and add a help text List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Tue, Sep 22, 2020 at 10:17:43AM +0200, Michael Olbrich wrote: > On Tue, Sep 22, 2020 at 12:17:25AM +0200, Roland Hieber wrote: > > The root.tgz is needed for all other rootfs images, so it makes sense to > > build it by default. Also provide at least one image by default for > > newly added platforms. > > No. Unused default stuff is never disabled unless it actually breaks > things. So in BSPs that don't actually use this, the image will probably > built anyways and just wastes space and time. OK, I'll add it to the new init_defconfig instead. - Roland > > Michael > > > Signed-off-by: Roland Hieber > > --- > > platforms/image-root-tgz.in | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/platforms/image-root-tgz.in b/platforms/image-root-tgz.in > > index c325209ded6d..cfd4f3f83600 100644 > > --- a/platforms/image-root-tgz.in > > +++ b/platforms/image-root-tgz.in > > @@ -2,9 +2,10 @@ > > > > menuconfig IMAGE_ROOT_TGZ > > tristate > > + default y > > prompt "Generate images/root.tgz " > > help > > - FIXME > > + Build a tar.gz archive containing the root file system. > > > > if IMAGE_ROOT_TGZ > > > > -- > > 2.28.0 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de