mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [ptxdist] [PATCH 4/7] image-root-tgz: build by default, and add a help text
Date: Tue, 22 Sep 2020 10:17:43 +0200	[thread overview]
Message-ID: <20200922081743.GE11021@pengutronix.de> (raw)
In-Reply-To: <20200921221728.3229-4-rhi@pengutronix.de>

On Tue, Sep 22, 2020 at 12:17:25AM +0200, Roland Hieber wrote:
> The root.tgz is needed for all other rootfs images, so it makes sense to
> build it by default. Also provide at least one image by default for
> newly added platforms.

No. Unused default stuff is never disabled unless it actually breaks
things. So in BSPs that don't actually use this, the image will probably
built anyways and just wastes space and time.

Michael

> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  platforms/image-root-tgz.in | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/platforms/image-root-tgz.in b/platforms/image-root-tgz.in
> index c325209ded6d..cfd4f3f83600 100644
> --- a/platforms/image-root-tgz.in
> +++ b/platforms/image-root-tgz.in
> @@ -2,9 +2,10 @@
>  
>  menuconfig IMAGE_ROOT_TGZ
>  	tristate
> +	default y
>  	prompt "Generate images/root.tgz      "
>  	help
> -	  FIXME
> +	  Build a tar.gz archive containing the root file system.
>  
>  if IMAGE_ROOT_TGZ
>  
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2020-09-22  8:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 22:17 [ptxdist] [PATCH 1/7] kernel: bump default version and md5sum Roland Hieber
2020-09-21 22:17 ` [ptxdist] [PATCH 2/7] platform: bump default toolchain version Roland Hieber
2020-09-21 22:17 ` [ptxdist] [PATCH 3/7] kernel, barebox: add descriptive help text for md5sum config options Roland Hieber
2020-09-21 22:17 ` [ptxdist] [PATCH 4/7] image-root-tgz: build by default, and add a help text Roland Hieber
2020-09-22  8:17   ` Michael Olbrich [this message]
2020-09-22  9:08     ` Roland Hieber
2020-09-21 22:17 ` [ptxdist] [PATCH 5/7] ptxdist: implement 'defconfig' commands for kconfig packages Roland Hieber
2020-09-22  8:26   ` Michael Olbrich
2020-09-21 22:17 ` [ptxdist] [PATCH 6/7] rules: move magic symbol into rules/ptxdist-version.in Roland Hieber
2020-09-21 22:17 ` [ptxdist] [PATCH 7/7] ptxdist: add 'init' commands to create new configs Roland Hieber
2020-09-22  9:46   ` Michael Olbrich
2020-09-23 12:22     ` Roland Hieber
2020-09-24 13:42       ` Michael Olbrich
2020-09-27 21:46         ` Roland Hieber
2020-09-22  8:13 ` [ptxdist] [PATCH 1/7] kernel: bump default version and md5sum Michael Olbrich
2020-09-22  9:17   ` Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922081743.GE11021@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox