mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] doc: highlight inline code with gray box
Date: Fri, 11 Sep 2020 12:08:27 +0200	[thread overview]
Message-ID: <20200911100827.GO13915@pengutronix.de> (raw)
In-Reply-To: <ad33d886372401e24e47eb18a476703bfbc3e3a0.camel@pengutronix.de>

On Fri, Sep 11, 2020 at 12:07:15PM +0200, Enrico Jörns wrote:
> Am Freitag, den 11.09.2020, 12:01 +0200 schrieb Michael Olbrich:
> > On Fri, Sep 11, 2020 at 11:23:31AM +0200, Enrico Jorns wrote:
> > > This should ease distinguishing inline code snippets from default text
> > > and is also more similar to what the sphinx html outputs look like.
> > > 
> > > Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
> > > ---
> > >  doc/preamble.inc | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/doc/preamble.inc b/doc/preamble.inc
> > > index d9e528ef4..3131987af 100644
> > > --- a/doc/preamble.inc
> > > +++ b/doc/preamble.inc
> > > @@ -82,6 +82,9 @@
> > >  \definecolor{VerbatimColor}{gray}{0.95}
> > >  \definecolor{VerbatimBorderColor}{gray}{0.75}
> > >  
> > > +% override default sphinxcode to display gray-colored box
> > > +\protected\def\sphinxcode#1{\fcolorbox[gray]{1}{0.9}{\texttt{#1}}}
> > 
> > Why 0.9 and not 0.95 like the VerbatimColor above? I would expect the same
> > color here.
> 
> That was my first guess, too. But at least on my screen it turned out
> that a quite small box with such a light gray and no darker border
> could be overseen.
> Thus one alternative would be to use the border here, too. If you like
> I can give it a try.

I think I'd prefer that. The different colors look strange to me.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2020-09-11 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  9:23 Enrico Jorns
2020-09-11 10:01 ` Michael Olbrich
2020-09-11 10:07   ` Enrico Jörns
2020-09-11 10:08     ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911100827.GO13915@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox