From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGfn5-0005Yt-TY for ptxdist@pengutronix.de; Fri, 11 Sep 2020 11:56:23 +0200 Received: from mol by dude02.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kGfn5-000558-LM for ptxdist@pengutronix.de; Fri, 11 Sep 2020 11:56:23 +0200 Date: Fri, 11 Sep 2020 11:56:23 +0200 From: Michael Olbrich Message-ID: <20200911095623.GG6156@pengutronix.de> References: <20200831211556.22254-1-rhi@pengutronix.de> <20200911080631.GD6156@pengutronix.de> <20200911081818.76zfbckomcffnp74@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200911081818.76zfbckomcffnp74@pengutronix.de> Subject: Re: [ptxdist] [PATCH 1/2] iproute2: add dependency to libcap List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Sep 11, 2020 at 10:18:18AM +0200, Roland Hieber wrote: > On Fri, Sep 11, 2020 at 10:06:31AM +0200, Michael Olbrich wrote: > > On Mon, Aug 31, 2020 at 11:15:55PM +0200, Roland Hieber wrote: > > > From: Robert Schwebel > > > > > > The handmade configure script in iproute2 doesn't correctly find libcap. > > > Enforce it to be there in any case. > > > > I don't see this here. The handmade configure script uses pkg-config. And > > the check for libcap is blocked: > > > > [...] > > libcap support: arm-v7a-linux-gnueabihf-pkg-config: warning: blocking 'libcap': not selected by 'iproute2' > > no > > [...] > > Yes, we were seeing this too: > > libcap support: yes > x86_64-unknown-linux-gnu-pkg-config: warning: blocking 'libcap': not selected by 'iproute2' > x86_64-unknown-linux-gnu-pkg-config: warning: blocking 'libcap': not selected by 'iproute2' > finished target iproute2.prepare > > but then later: > > /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ../lib/libutil.a(utils.o): in function `drop_cap': > utils.c:(.text+0x2972): undefined reference to `cap_get_proc' > /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x2991): undefined reference to `cap_get_flag' > /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29a5): undefined reference to `cap_clear' > /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29b1): undefined reference to `cap_set_proc' > /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29bd): undefined reference to `cap_free' > collect2: error: ld returned 1 exit status > > If you want to investigate more, see > > (internal PTX net only). > > It could be related to libcap being installed on the build host, at > least the package doesn't fail to build on systems where it isn't > installed, and there is also no HAVE_LIBCAP in iproute2-5.7.0/config.mk. This is a race condition in our pkg-config wrapper. The libcap.pc shows up right in the middle and the wrapper does not handle this correctly. I'm working on a fix for this. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de