mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/2] iproute2: add dependency to libcap
Date: Fri, 11 Sep 2020 11:56:23 +0200	[thread overview]
Message-ID: <20200911095623.GG6156@pengutronix.de> (raw)
In-Reply-To: <20200911081818.76zfbckomcffnp74@pengutronix.de>

On Fri, Sep 11, 2020 at 10:18:18AM +0200, Roland Hieber wrote:
> On Fri, Sep 11, 2020 at 10:06:31AM +0200, Michael Olbrich wrote:
> > On Mon, Aug 31, 2020 at 11:15:55PM +0200, Roland Hieber wrote:
> > > From: Robert Schwebel <r.schwebel@pengutronix.de>
> > > 
> > > The handmade configure script in iproute2 doesn't correctly find libcap.
> > > Enforce it to be there in any case.
> > 
> > I don't see this here. The handmade configure script uses pkg-config. And
> > the check for libcap is blocked:
> > 
> > [...]
> > libcap support: arm-v7a-linux-gnueabihf-pkg-config: warning: blocking 'libcap': not selected by 'iproute2'
> > no
> > [...]
> 
> Yes, we were seeing this too:
> 
>     libcap support: yes
>     x86_64-unknown-linux-gnu-pkg-config: warning: blocking 'libcap': not selected by 'iproute2'
>     x86_64-unknown-linux-gnu-pkg-config: warning: blocking 'libcap': not selected by 'iproute2'
>     finished target iproute2.prepare
> 
> but then later: 
> 
>     /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: ../lib/libutil.a(utils.o): in function `drop_cap':
>     utils.c:(.text+0x2972): undefined reference to `cap_get_proc'
>     /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x2991): undefined reference to `cap_get_flag'
>     /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29a5): undefined reference to `cap_clear'
>     /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29b1): undefined reference to `cap_set_proc'
>     /opt/OSELAS.Toolchain-2020.08.0/x86_64-unknown-linux-gnu/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/x86_64-unknown-linux-gnu/10.2.1/../../../../x86_64-unknown-linux-gnu/bin/ld: utils.c:(.text+0x29bd): undefined reference to `cap_free'
>     collect2: error: ld returned 1 exit status
> 
> If you want to investigate more, see
> <http://jenkins.hi.pengutronix.de/job/ptxdist-bsps/job/DistroKit/job/next-x86_64/20/artifact/platform-x86_64/logfile/*view*/>
> (internal PTX net only).
> 
> It could be related to libcap being installed on the build host, at
> least the package doesn't fail to build on systems where it isn't
> installed, and there is also no HAVE_LIBCAP in iproute2-5.7.0/config.mk.

This is a race condition in our pkg-config wrapper. The libcap.pc shows up
right in the middle and the wrapper does not handle this correctly. I'm
working on a fix for this.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

      reply	other threads:[~2020-09-11  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 21:15 Roland Hieber
2020-08-31 21:15 ` [ptxdist] [PATCH 2/2] iproute2: align conditionals Roland Hieber
2020-09-16 10:05   ` [ptxdist] [PATCH v2] iproute2: align select conditionals and sort by name Roland Hieber
2020-10-06  8:18     ` [ptxdist] [APPLIED] " Michael Olbrich
2020-09-11  8:06 ` [ptxdist] [PATCH 1/2] iproute2: add dependency to libcap Michael Olbrich
2020-09-11  8:18   ` Roland Hieber
2020-09-11  9:56     ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911095623.GG6156@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox