Re: [ptxdist] [PATCH] sudo: targetinstall /etc/sudoers.d with 4 digit permission

[Roland Hieber <rhi@pengutronix.de>]

On Wed, Aug 19, 2020 at 01:11:35PM +0200, Alexander Dahl wrote:
> Hello Roland,
> 
> Am Mittwoch, 19. August 2020, 12:47:22 CEST schrieb Roland Hieber:
> > On Tue, Aug 18, 2020 at 12:35:32PM +0200, Alexander Dahl wrote:
> > > When installing additional files into /etc/sudoers.d from another
> > > 
> > > package, we got this error (redacted):
> > >   Incompatible ownership or permissions for '/etc/sudoers.d':
> > >   sudo: 0.0 755
> > >   *****: 0.0 0755 (implicit)
> > >   
> > >   One of these packages must be fixed!
> > > 
> > > Build is successful again, if fixed in the sudo package.
> > > 
> > > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > > ---
> > > 
> > > Notes:
> > >     Besides: how would one fix this in the other package? I have that case
> > >     for another set of packages where one creates a folder with 2775 and
> > >     others should copy files in it, which fails because 0755 are the
> > >     implicit rights. Recreate that folder in each package?
> > 
> > A start could be to grep for install_copy calls and sort them by their
> > last parameter:
> > 
> >     git grep  '$(call install_copy,' | sort -k 8
> > 
> > … but we still need to handle those lines which are wrapped using a \ at
> > the end…
> 
> I think you misunderstood what I meant. Let me give an example. Assume package 
> 'foo' creates a folder like this:
> 
> 	@$(call install_copy, foo, root, daemon, 2775, /etc/daemon)
> 
> And now another package 'bar' installs a file like this:
> 
> 	@$(call install_alternative, bar, root, root, 0644, /etc/daemon/bar)
> 
> This will clash with an error message (roughly) like this:
> 
>   Incompatible ownership or permissions for '/etc/daemon':
>   foo: 0.1 2775
>   bar: 0.0 0755 (implicit)
>   
>   One of these packages must be fixed!
> 
> Now the question again: how would one fix this in package 'bar' without 
> touching package 'foo'?

Ah yes, I misunderstood what you meant! :) Does an additional
install_copy for the directory with the same permissions as in the other
package should do the job already?

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de