From: Roland Hieber <rhi@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [PATCH 2/2] rules: explicitly specify sticky/setuid/setgid bits for install_* macros
Date: Wed, 19 Aug 2020 12:55:10 +0200 [thread overview]
Message-ID: <20200819105510.w46bqona6ignistf@pengutronix.de> (raw)
In-Reply-To: <20200819105118.16294-2-rhi@pengutronix.de>
On Wed, Aug 19, 2020 at 12:51:18PM +0200, Roland Hieber wrote:
> Until now the bits were implied to be 0, but we should be specific here.
> All other packages already use the four-digit variant.
>
> These instances were found by using:
>
> git grep -e 'call install_\(alternative\|copy\|lib\), [^,]\+, [^,]\+, [^,]\+, [0-9][0-9][0-9][^0-9]'
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>
> On Wed, Aug 19, 2020 at 12:47:22PM +0200, Roland Hieber wrote:
> > On Tue, Aug 18, 2020 at 12:35:32PM +0200, Alexander Dahl wrote:
> > > rules/sudo.make | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/rules/sudo.make b/rules/sudo.make
> > > index 985ab8768..dd8c1bb67 100644
> > > --- a/rules/sudo.make
> > > +++ b/rules/sudo.make
> > > @@ -133,7 +133,7 @@ $(STATEDIR)/sudo.targetinstall:
> > >
> > > ifdef PTXCONF_SUDO_INSTALL_ETC_SUDOERS
> > > @$(call install_alternative, sudo, 0, 0, 0440, /etc/sudoers, n)
> > > - @$(call install_copy, sudo, 0, 0, 755, /etc/sudoers.d)
> > > + @$(call install_copy, sudo, 0, 0, 0755, /etc/sudoers.d)
> >
> > Huh, there are a lot of other instances of install_copy where the
> > three-digit variant is used… I guess we should fix them once for all.
>
> I just took the liberty :-)
>
>
> rules/busybox.make | 4 ++--
> rules/cog.make | 4 ++--
> rules/cups.make | 2 +-
> rules/flex.make | 2 +-
> rules/gpsd.make | 6 +++---
> rules/graphene.make | 2 +-
> rules/gst-bayer2rgb-neon.make | 2 +-
> rules/gst-rtsp-server1.make | 2 +-
> rules/gst-validate1.make | 2 +-
> rules/intel-gmmlib.make | 2 +-
> rules/libpaper.make | 4 ++--
> rules/libsrtp.make | 2 +-
> rules/pango.make | 2 +-
> rules/piglit.make | 2 +-
> rules/polkit.make | 2 +-
> rules/python.make | 6 +++---
> rules/python3.make | 6 +++---
> rules/sdl2-test.make | 4 ++--
> rules/strongswan.make | 26 +++++++++++++-------------
> rules/sudo.make | 4 ++--
> rules/systemd.make | 2 +-
> rules/templates/template-kernel-make | 2 +-
Hmm, this one was not supposed to be in there. Also I just noticed that
Alex's patch was already applied, so let me rebase this.
- Roland
> rules/xorg-font-ttf-caladea.make | 4 ++--
> rules/xorg-font-ttf-carlito.make | 4 ++--
> 24 files changed, 49 insertions(+), 49 deletions(-)
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
next prev parent reply other threads:[~2020-08-19 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 10:35 [ptxdist] [PATCH] sudo: targetinstall /etc/sudoers.d with 4 digit permission Alexander Dahl
2020-08-19 10:47 ` Roland Hieber
2020-08-19 10:51 ` [ptxdist] [PATCH 1/2] doc: ref_make_macros: make clear that permission should be four digits Roland Hieber
2020-08-19 10:51 ` [ptxdist] [PATCH 2/2] rules: explicitly specify sticky/setuid/setgid bits for install_* macros Roland Hieber
2020-08-19 10:55 ` Roland Hieber [this message]
2020-08-19 10:59 ` [ptxdist] [PATCH v2 1/2] doc: ref_make_macros: make clear that permission should be four digits Roland Hieber
2020-08-19 10:59 ` [ptxdist] [PATCH v2 2/2] rules: explicitly specify sticky/setuid/setgid bits for install_* macros Roland Hieber
2020-09-04 17:01 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-19 11:04 ` [ptxdist] [PATCH v2 1/2] doc: ref_make_macros: make clear that permission should be four digits Alexander Dahl
2020-08-21 7:52 ` Michael Olbrich
2020-08-21 12:06 ` Alexander Dahl
2020-08-23 19:17 ` Roland Hieber
2020-09-04 17:01 ` [ptxdist] [APPLIED] " Michael Olbrich
2020-08-19 11:11 ` [ptxdist] [PATCH] sudo: targetinstall /etc/sudoers.d with 4 digit permission Alexander Dahl
2020-08-19 11:29 ` Roland Hieber
2020-08-21 6:54 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819105510.w46bqona6ignistf@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=ada@thorsis.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox