Re: [ptxdist] [PATCH] sudo: targetinstall /etc/sudoers.d with 4 digit permission

[Roland Hieber <rhi@pengutronix.de>]

On Tue, Aug 18, 2020 at 12:35:32PM +0200, Alexander Dahl wrote:
> When installing additional files into /etc/sudoers.d from another
> package, we got this error (redacted):
> 
>   Incompatible ownership or permissions for '/etc/sudoers.d':
>   sudo: 0.0 755
>   *****: 0.0 0755 (implicit)
> 
>   One of these packages must be fixed!
> 
> Build is successful again, if fixed in the sudo package.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> 
> Notes:
>     Besides: how would one fix this in the other package? I have that case
>     for another set of packages where one creates a folder with 2775 and
>     others should copy files in it, which fails because 0755 are the
>     implicit rights. Recreate that folder in each package?

A start could be to grep for install_copy calls and sort them by their
last parameter:

    git grep  '$(call install_copy,' | sort -k 8

… but we still need to handle those lines which are wrapped using a \ at
the end…

>  rules/sudo.make | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rules/sudo.make b/rules/sudo.make
> index 985ab8768..dd8c1bb67 100644
> --- a/rules/sudo.make
> +++ b/rules/sudo.make
> @@ -133,7 +133,7 @@ $(STATEDIR)/sudo.targetinstall:
>  
>  ifdef PTXCONF_SUDO_INSTALL_ETC_SUDOERS
>  	@$(call install_alternative, sudo, 0, 0, 0440, /etc/sudoers, n)
> -	@$(call install_copy, sudo, 0, 0, 755, /etc/sudoers.d)
> +	@$(call install_copy, sudo, 0, 0, 0755, /etc/sudoers.d)

Huh, there are a lot of other instances of install_copy where the
three-digit variant is used… I guess we should fix them once for all.

 - Roland

>  endif
>  
>  ifdef PTXCONF_SUDO_INSTALL_VISUDO
> -- 
> 2.27.0
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de